diff --git a/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt index 71e2d96e3..2b2971807 100644 --- a/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt @@ -8,6 +8,7 @@ import android.content.Context import android.view.View import androidx.navigation.fragment.navArgs import kotlinx.android.synthetic.main.component_browser_top_toolbar.* +import kotlinx.android.synthetic.main.fragment_browser.* import kotlinx.android.synthetic.main.fragment_browser.view.* import kotlinx.coroutines.ExperimentalCoroutinesApi import mozilla.components.browser.session.Session @@ -105,6 +106,7 @@ class ExternalAppBrowserFragment : BaseBrowserFragment(), UserInteractionHandler customTabSessionId, trustedScopes ) { toolbarVisible -> + if (!toolbarVisible) { engineView.setDynamicToolbarMaxHeight(0) } if (!FeatureFlags.dynamicBottomToolbar) { updateLayoutMargins(inFullScreen = !toolbarVisible) } }, owner = this, diff --git a/docs/metrics.md b/docs/metrics.md index 06ec9ad7e..7b23baad6 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -19,6 +19,15 @@ This means you might have to go searching through the dependency tree to get a f This ping is intended to provide a measure of the activation of mobile products. It's generated when Fenix starts, right after Glean is initialized. It doesn't include the client_id, since it might be reporting an hashed version of the Google Advertising ID. +**Data reviews for this ping:** + +- + +**Bugs related to this ping:** + +- 1538011 +- 1501822 + The following metrics are added to the ping: | Name | Type | Description | Data reviews | Extras | Expiration | @@ -185,6 +194,16 @@ The following metrics are added to the ping: This ping is intended to capture the source of the installation +This ping includes the [client id](https://mozilla.github.io/glean/book/user/pings/index.html#the-client_info-section). + +**Data reviews for this ping:** + +- + +**Bugs related to this ping:** + +- + The following metrics are added to the ping: | Name | Type | Description | Data reviews | Extras | Expiration |