diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt index 3bfc5f723..2f22a9ada 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt @@ -92,8 +92,8 @@ class EditBookmarkFragment : Fragment(), CoroutineScope { bookmark_name_edit.setText(bookmarkNode!!.title) bookmark_url_edit.setText(bookmarkNode!!.url) - if (sharedViewModel.selectedFolder != null) { - val bookmarkPair = Pair(bookmarkNode?.title!!, bookmarkNode?.url!!) + if (sharedViewModel.selectedFolder != null && bookmarkNode?.title != null) { + val bookmarkPair = Pair(bookmarkNode?.title, bookmarkNode?.url) updateBookmarkNode(bookmarkPair) } } @@ -160,7 +160,7 @@ class EditBookmarkFragment : Fragment(), CoroutineScope { } } - private fun updateBookmarkNode(pair: Pair) { + private fun updateBookmarkNode(pair: Pair) { launch(IO) { try { requireComponents.let { diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt index 20c0e7f83..ed2d0db57 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt @@ -15,7 +15,7 @@ import mozilla.components.concept.storage.BookmarkNode import mozilla.components.concept.storage.BookmarkNodeType import mozilla.components.support.ktx.android.content.res.pxToDp import org.mozilla.fenix.R -import org.mozilla.fenix.ext.getColorFromAttr +import org.mozilla.fenix.ext.getColorIntFromAttr import org.mozilla.fenix.library.bookmarks.BookmarksSharedViewModel class SelectBookmarkFolderAdapter(private val sharedViewModel: BookmarksSharedViewModel) : @@ -86,9 +86,9 @@ class SelectBookmarkFolderAdapter(private val sharedViewModel: BookmarksSharedVi fun bind(folder: BookmarkNodeWithDepth, selected: Boolean, selectionInterface: SelectionInterface) { val backgroundTint = if (selected) { - R.attr.accent.getColorFromAttr(containerView!!.context) + R.attr.accentBright.getColorIntFromAttr(containerView!!.context) } else { - R.attr.neutral.getColorFromAttr(containerView!!.context) + R.attr.neutral.getColorIntFromAttr(containerView!!.context) } val backgroundTintList = ContextCompat.getColorStateList(containerView.context, backgroundTint) diff --git a/app/src/main/res/drawable/fenix_snackbar_background.xml b/app/src/main/res/drawable/fenix_snackbar_background.xml index f2f3be41a..a9747fa49 100644 --- a/app/src/main/res/drawable/fenix_snackbar_background.xml +++ b/app/src/main/res/drawable/fenix_snackbar_background.xml @@ -4,6 +4,6 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> - + diff --git a/app/src/main/res/drawable/ic_folder_icon.xml b/app/src/main/res/drawable/ic_folder_icon.xml index 5afbf9574..98ac87a1b 100644 --- a/app/src/main/res/drawable/ic_folder_icon.xml +++ b/app/src/main/res/drawable/ic_folder_icon.xml @@ -1,7 +1,6 @@ - +