From 7ab534705a1f43b25bbb0cbeaa2fab238b808fd8 Mon Sep 17 00:00:00 2001
From: wpanas <8766331+wpanas@users.noreply.github.com>
Date: Thu, 24 Oct 2019 19:52:30 +0200
Subject: [PATCH] Closes #6236: Fix padding lint issues (#6240)

---
 app/src/main/res/layout/account_preference.xml                 | 1 +
 .../main/res/layout/component_tracking_protection_panel.xml    | 2 ++
 app/src/main/res/layout/fragment_add_new_device.xml            | 1 +
 app/src/main/res/layout/fragment_create_shortcut.xml           | 1 +
 .../main/res/layout/fragment_quick_settings_dialog_sheet.xml   | 2 ++
 .../main/res/layout/fragment_tracking_protection_blocking.xml  | 1 +
 app/src/main/res/layout/layout_percentage_seek_bar.xml         | 2 ++
 app/src/main/res/layout/layout_url_background.xml              | 3 ++-
 8 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/account_preference.xml b/app/src/main/res/layout/account_preference.xml
index 530f0c60b..bac656151 100644
--- a/app/src/main/res/layout/account_preference.xml
+++ b/app/src/main/res/layout/account_preference.xml
@@ -32,6 +32,7 @@
         android:layout_marginEnd="6dp"
         android:layout_weight="1"
         android:paddingStart="16dp"
+        android:paddingEnd="0dp"
         android:paddingTop="16dp"
         android:paddingBottom="16dp">
 
diff --git a/app/src/main/res/layout/component_tracking_protection_panel.xml b/app/src/main/res/layout/component_tracking_protection_panel.xml
index 8dbbf56ff..7d4f99640 100644
--- a/app/src/main/res/layout/component_tracking_protection_panel.xml
+++ b/app/src/main/res/layout/component_tracking_protection_panel.xml
@@ -163,6 +163,7 @@
             style="@style/QuickSettingsText.Icon"
             android:layout_width="match_parent"
             android:layout_height="@dimen/tracking_protection_item_height"
+            android:paddingStart="0dp"
             android:paddingEnd="24dp"
             android:text="@string/etp_settings"
             app:drawableStartCompat="@drawable/ic_settings"
@@ -229,6 +230,7 @@
             android:layout_marginStart="52dp"
             android:layout_marginEnd="26dp"
             android:paddingStart="0dp"
+            android:paddingEnd="0dp"
             android:text="@string/enhanced_tracking_protection_blocked"
             android:textStyle="bold"
             app:layout_constraintStart_toStartOf="parent"
diff --git a/app/src/main/res/layout/fragment_add_new_device.xml b/app/src/main/res/layout/fragment_add_new_device.xml
index e29bf14ca..59897d3cb 100644
--- a/app/src/main/res/layout/fragment_add_new_device.xml
+++ b/app/src/main/res/layout/fragment_add_new_device.xml
@@ -34,6 +34,7 @@
             android:layout_height="wrap_content"
             android:layout_marginStart="15dp"
             android:layout_marginEnd="6dp"
+            android:paddingStart="0dp"
             android:paddingEnd="0dp"
             android:paddingTop="16dp"
             android:paddingBottom="16dp"
diff --git a/app/src/main/res/layout/fragment_create_shortcut.xml b/app/src/main/res/layout/fragment_create_shortcut.xml
index da8b52481..7160d2178 100644
--- a/app/src/main/res/layout/fragment_create_shortcut.xml
+++ b/app/src/main/res/layout/fragment_create_shortcut.xml
@@ -23,6 +23,7 @@
         android:paddingTop="16dp"
         android:paddingBottom="16dp"
         android:paddingStart="32dp"
+        android:paddingEnd="0dp"
         android:background="@drawable/dialog_background">
         <TextView
             android:id="@+id/dialog_title"
diff --git a/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml b/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml
index 9003da9d7..732305e20 100644
--- a/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml
+++ b/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml
@@ -74,6 +74,7 @@
                 android:layout_height="@dimen/quicksettings_item_height"
                 android:gravity="top"
                 android:paddingStart="48dp"
+                android:paddingEnd="0dp"
                 android:text="@string/preferences_tracking_protection_turned_off_globally"
                 android:textColor="?accentBright"
                 android:visibility="gone"
@@ -87,6 +88,7 @@
                 android:layout_height="@dimen/quicksettings_item_height"
                 android:gravity="top"
                 android:paddingStart="48dp"
+                android:paddingEnd="0dp"
                 android:text="@string/browser_menu_report_issue"
                 android:textColor="?accentUsedOnDarkBackground"
                 app:layout_constraintBottom_toTopOf="@id/line_divider"
diff --git a/app/src/main/res/layout/fragment_tracking_protection_blocking.xml b/app/src/main/res/layout/fragment_tracking_protection_blocking.xml
index 857fa8973..0fe88a045 100644
--- a/app/src/main/res/layout/fragment_tracking_protection_blocking.xml
+++ b/app/src/main/res/layout/fragment_tracking_protection_blocking.xml
@@ -19,6 +19,7 @@
             android:layout_marginStart="16dp"
             android:layout_marginEnd="16dp"
             android:paddingStart="0dp"
+            android:paddingEnd="0dp"
             android:text="@string/enhanced_tracking_protection_blocked"
             android:textStyle="bold" />
 
diff --git a/app/src/main/res/layout/layout_percentage_seek_bar.xml b/app/src/main/res/layout/layout_percentage_seek_bar.xml
index edb901e56..f7004cf6f 100644
--- a/app/src/main/res/layout/layout_percentage_seek_bar.xml
+++ b/app/src/main/res/layout/layout_percentage_seek_bar.xml
@@ -36,6 +36,7 @@
         android:id="@+id/seekbar"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
+        android:paddingStart="0dp"
         android:paddingEnd="60dp"
         app:layout_constraintBottom_toBottomOf="@+id/seekbar_value"
         app:layout_constraintEnd_toEndOf="parent"
@@ -50,6 +51,7 @@
         android:layout_marginBottom="30dp"
         android:gravity="end|center_vertical"
         android:paddingStart="16dp"
+        android:paddingEnd="0dp"
         tools:text="200%"
         android:textColor="?attr/primaryText"
         android:textSize="16sp"
diff --git a/app/src/main/res/layout/layout_url_background.xml b/app/src/main/res/layout/layout_url_background.xml
index 6375fd3e0..da7b45fae 100644
--- a/app/src/main/res/layout/layout_url_background.xml
+++ b/app/src/main/res/layout/layout_url_background.xml
@@ -5,7 +5,8 @@
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
-    android:paddingStart="8dp">
+    android:paddingStart="8dp"
+    android:paddingEnd="0dp">
 
     <View
         android:layout_width="wrap_content"