blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #12364 - Improve PWA onboarding timing logic

master
ekager 2020-07-23 20:25:39 -04:00 committed by Emily Kager
parent 9c56e1905b
commit 6edbb82591
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/mozilla/fenix/shortcut/PwaOnboardingObserver.kt
View File

@ -6,7 +6,6 @@ package org.mozilla.fenix.shortcut
import androidx.navigation.NavController
import mozilla.components.browser.session.Session
import mozilla.components.concept.engine.manifest.WebAppManifest
import mozilla.components.feature.pwa.WebAppUseCases
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.BrowserFragmentDirections
@ -22,8 +21,8 @@ class PwaOnboardingObserver(
private val webAppUseCases: WebAppUseCases
) : Session.Observer {
override fun onWebAppManifestChanged(session: Session, manifest: WebAppManifest?) {
if (webAppUseCases.isInstallable() && !settings.userKnowsAboutPwas) {
override fun onLoadingStateChanged(session: Session, loading: Boolean) {
if (!loading && webAppUseCases.isInstallable() && !settings.userKnowsAboutPwas) {
settings.incrementVisitedInstallableCount()
if (settings.shouldShowPwaOnboarding) {
val directions =