From 6b8938e47ec25f00acec34605faef4b826cc33b7 Mon Sep 17 00:00:00 2001 From: Denys M Date: Thu, 23 May 2019 23:14:52 +0300 Subject: [PATCH] Fixes #2739. Update sign-in preference visibility when screen is resumed. --- .../main/java/org/mozilla/fenix/settings/SettingsFragment.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index 18148303b..4e38e1baa 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -52,7 +52,7 @@ import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.utils.ItsNotBrokenSnack import kotlin.coroutines.CoroutineContext -@SuppressWarnings("TooManyFunctions") +@SuppressWarnings("TooManyFunctions", "LargeClass") class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObserver { private lateinit var job: Job override val coroutineContext: CoroutineContext @@ -61,7 +61,6 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) job = Job() - updateSignInVisibility() preferenceManager.sharedPreferences.registerOnSharedPreferenceChangeListener { sharedPreferences, key -> try { @@ -118,6 +117,7 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse setupPreferences() setupAccountUI() + updateSignInVisibility() } @Suppress("ComplexMethod") @@ -283,6 +283,7 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse override fun onAuthenticated(account: OAuthAccount) { updateAuthState(account) + updateSignInVisibility() } override fun onError(error: Exception) {