From 66a8c049673b5984d0eb737c97d7d81f93511cbb Mon Sep 17 00:00:00 2001 From: Suraj Shah Date: Wed, 28 Aug 2019 22:42:39 +0530 Subject: [PATCH] Fixes #4488: Shows snackbar on bookmark deletion from edit fragment (#4792) * Fixes #4488 Updates changelog * Removes wildcard imports. * Removes custom label in use, replaces with let --- .../bookmarks/edit/EditBookmarkFragment.kt | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt index efb47d945..9e487fdc4 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt @@ -38,12 +38,15 @@ import mozilla.components.concept.storage.BookmarkNode import mozilla.components.concept.storage.BookmarkNodeType import mozilla.components.support.ktx.android.view.hideKeyboard import org.mozilla.fenix.R +import org.mozilla.fenix.components.FenixSnackbar import org.mozilla.fenix.components.metrics.Event import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.ext.nav import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.ext.setRootTitles import org.mozilla.fenix.ext.withRootTitle +import org.mozilla.fenix.ext.getRootView +import org.mozilla.fenix.ext.urlToTrimmedHost import org.mozilla.fenix.library.bookmarks.BookmarksSharedViewModel import java.util.concurrent.TimeUnit @@ -175,8 +178,20 @@ class EditBookmarkFragment : Fragment() { lifecycleScope.launch(IO) { requireComponents.core.bookmarksStorage.deleteNode(guidToEdit) requireComponents.analytics.metrics.track(Event.RemoveBookmark) + launch(Main) { Navigation.findNavController(requireActivity(), R.id.container).popBackStack() + activity.getRootView()?.let { rootView -> + bookmarkNode?.let { + FenixSnackbar.make(rootView, FenixSnackbar.LENGTH_SHORT) + .setText( + getString(R.string.bookmark_deletion_snackbar_message, + it.url?.urlToTrimmedHost(activity) ?: it.title + ) + ) + .show() + } + } } } dialog.dismiss()