From 5971257669f3517ae8ceef4e3a9e50804dae9976 Mon Sep 17 00:00:00 2001 From: Sparky93 Date: Fri, 14 Feb 2020 13:37:50 +0200 Subject: [PATCH] Fix for #8430 - Migration progress bar too close to text Reduced the margin start value of the progress bar in order to leave more space between it and the text. Moved hardcoded margin values into dimens resources. --- app/src/main/res/layout/activity_migration.xml | 6 +++--- app/src/main/res/values/dimens.xml | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/layout/activity_migration.xml b/app/src/main/res/layout/activity_migration.xml index d30c130a5..2b0443d38 100644 --- a/app/src/main/res/layout/activity_migration.xml +++ b/app/src/main/res/layout/activity_migration.xml @@ -104,9 +104,9 @@ style="@style/Widget.AppCompat.ProgressBar" android:layout_width="@dimen/migration_progress_size" android:layout_height="@dimen/migration_progress_size" - android:layout_marginStart="8dp" - android:layout_marginTop="8dp" - android:layout_marginBottom="8dp" + android:layout_marginStart="@dimen/migration_progress_margin_start" + android:layout_marginTop="@dimen/migration_progress_margin_vertical" + android:layout_marginBottom="@dimen/migration_progress_margin_vertical" app:layout_constraintBottom_toBottomOf="@+id/migration_button" app:layout_constraintStart_toStartOf="@+id/migration_button" app:layout_constraintTop_toTopOf="@+id/migration_button" /> diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 8f8d12a30..80f44aacc 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -112,5 +112,7 @@ 16sp 20sp 24dp + 8dp + 4dp