1
0
Fork 0

Bug 1627027 - part 2: Do not run perf tasks on Nd-gp graphs (#10681)

master
Johan Lorenzo 2020-05-15 16:29:02 +02:00 committed by GitHub
parent fee37e4f12
commit 553b1ae42b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 3 deletions

View File

@ -22,6 +22,7 @@ only-for-abis:
job-defaults:
attributes:
artifact_prefix: public/test_info
nightly: true
dependencies:
geckoview-nightly: geckoview-nightly
notify:

View File

@ -19,6 +19,7 @@ only-for-abis:
job-defaults:
attributes:
nightly: true
retrigger: true
dependencies:
geckoview-nightly: geckoview-nightly

View File

@ -22,6 +22,8 @@ transforms:
- taskgraph.transforms.task:transforms
job-template:
attributes:
nightly: true
description: "Run visual metrics calculations on Raptor"
run-on-projects: []
run-on-tasks-for: []

View File

@ -33,8 +33,7 @@ def target_tasks_nightly(full_task_graph, parameters, graph_config):
def filter(task, parameters):
# We don't want to ship nightly while Google Play is still behind manual review.
# See bug 1628413 for more context.
return task.attributes.get("nightly", False) and task.kind != "push-apk" or \
task.kind in ('browsertime', 'visual-metrics', 'raptor')
return task.attributes.get("nightly", False) and task.kind != "push-apk"
return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)]
@ -44,7 +43,13 @@ def target_tasks_nightly_on_google_play(full_task_graph, parameters, graph_confi
"""Select the set of tasks required for a nightly build that goes on Google Play."""
def filter(task, parameters):
return task.attributes.get("nightly", False)
return (
task.attributes.get("nightly", False) and
# This target_task is temporary while Google Play processes APKs slower than usually
# (bug 1628413). So we want this target task to be only about shipping APKs to GP and
# not doing any other miscellaneous tasks like performance testing
task.kind not in ("browsertime", "visual-metrics", "raptor")
)
return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)]