From 1816fbf49f7dc1a6be2b0c2e1f51c02c1fcc4bb2 Mon Sep 17 00:00:00 2001 From: Michael Droettboom Date: Mon, 10 Aug 2020 09:11:42 -0400 Subject: [PATCH 1/9] Bug 1608838: Add data sensitivity metadata --- app/metrics.yaml | 524 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 524 insertions(+) diff --git a/app/metrics.yaml b/app/metrics.yaml index 5a15283cb..230f67c14 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -34,6 +34,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/11830 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12114#pullrequestreview-445245341 + data_sensitivity: + - interaction notification_emails: - esmyth@mozilla.com - perf-android-fe@mozilla.com @@ -78,6 +80,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/10616 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673 + data_sensitivity: + - interaction notification_emails: - telemetry-client-dev@mozilla.com - fenix-core@mozilla.com @@ -95,6 +99,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/959 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -111,6 +117,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/959 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -133,6 +141,8 @@ events: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673 - https://github.com/mozilla-mobile/fenix/pull/1677 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -156,6 +166,8 @@ events: - https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708 - https://github.com/mozilla-mobile/fenix/pull/5098#issuecomment-529658996 - https://github.com/mozilla-mobile/fenix/pull/6310 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -175,6 +187,8 @@ events: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1785 - https://github.com/mozilla-mobile/fenix/pull/8314 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -213,6 +227,9 @@ events: - https://github.com/mozilla-mobile/fenix/pull/6352 - https://github.com/mozilla-mobile/fenix/pull/6601 - https://github.com/mozilla-mobile/fenix/pull/6746 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -224,6 +241,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/5021 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5090 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -239,6 +258,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/5737 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5975 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -257,6 +278,8 @@ events: - https://github.com/mozilla-mobile/fenix/issues/11442 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11533 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -270,6 +293,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -282,6 +307,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -294,6 +321,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -306,6 +335,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -323,6 +354,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -340,6 +373,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -352,6 +387,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -369,6 +406,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -381,6 +420,8 @@ onboarding: - https://github.com/mozilla-mobile/fenix/issues/10824 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11867 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -416,6 +457,8 @@ toolbar_settings: - https://github.com/mozilla-mobile/fenix/issues/6054 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6608 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -429,6 +472,8 @@ crash_reporter: - https://github.com/mozilla-mobile/fenix/issues/1040 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -445,6 +490,8 @@ crash_reporter: - https://github.com/mozilla-mobile/fenix/issues/1040 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -467,6 +514,8 @@ context_menu: - https://github.com/mozilla-mobile/fenix/issues/957 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1344#issuecomment-479285010 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -480,6 +529,8 @@ login_dialog: - https://github.com/mozilla-mobile/fenix/issues/9730 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13050 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -491,6 +542,8 @@ login_dialog: - https://github.com/mozilla-mobile/fenix/issues/9730 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13050 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -502,6 +555,8 @@ login_dialog: - https://github.com/mozilla-mobile/fenix/issues/9730 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13050 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -513,6 +568,8 @@ login_dialog: - https://github.com/mozilla-mobile/fenix/issues/9730 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13050 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -526,6 +583,8 @@ find_in_page: - https://github.com/mozilla-mobile/fenix/issues/1036 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1344#issuecomment-479285010 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -537,6 +596,8 @@ find_in_page: - https://github.com/mozilla-mobile/fenix/issues/1036 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1344#issuecomment-479285010 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -548,6 +609,8 @@ find_in_page: - https://github.com/mozilla-mobile/fenix/issues/1036 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1344#issuecomment-479285010 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -564,6 +627,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/960 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -582,6 +647,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/8125 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9556 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -596,6 +663,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/8125 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9556 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -618,6 +687,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/11909 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11982#pullrequestreview-437963817 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-12-01" @@ -633,6 +704,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/11909 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11982#pullrequestreview-437963817 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-12-01" @@ -658,6 +731,9 @@ metrics: - https://github.com/mozilla-mobile/fenix/pull/1677 - https://github.com/mozilla-mobile/fenix/pull/5216 - https://github.com/mozilla-mobile/fenix/pull/7310 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -676,6 +752,9 @@ metrics: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1953/ - https://github.com/mozilla-mobile/fenix/pull/5216 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -692,6 +771,9 @@ metrics: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1953/ - https://github.com/mozilla-mobile/fenix/pull/5216 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -709,6 +791,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/9136 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5579 + data_sensitivity: + - technical notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -726,6 +810,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/9136 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9253 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -743,6 +829,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/9136 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9253 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -760,6 +848,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/9136 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9253 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -774,6 +864,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/6054 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6608 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -788,6 +880,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/9488 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10958 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -806,6 +900,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/11479 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12024 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -820,6 +916,8 @@ metrics: - https://github.com/mozilla-mobile/fenix/issues/11479 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12024 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -836,6 +934,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -850,6 +950,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -866,6 +968,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -881,6 +985,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -895,6 +1001,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -909,6 +1017,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -923,6 +1033,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -937,6 +1049,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -951,6 +1065,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -965,6 +1081,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -981,6 +1099,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -995,6 +1115,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1010,6 +1132,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1024,6 +1148,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1039,6 +1165,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11211 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1053,6 +1181,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11446 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1067,6 +1197,8 @@ preferences: - https://github.com/mozilla-mobile/fenix/issues/11118 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11446 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1087,6 +1219,9 @@ search.default_engine: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1606 - https://github.com/mozilla-mobile/fenix/pull/5216 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1105,6 +1240,9 @@ search.default_engine: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1606 - https://github.com/mozilla-mobile/fenix/pull/5216 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1124,6 +1262,9 @@ search.default_engine: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1606 - https://github.com/mozilla-mobile/fenix/pull/5216 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1137,6 +1278,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1148,6 +1291,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1159,6 +1304,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1170,6 +1317,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1181,6 +1330,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1192,6 +1343,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1203,6 +1356,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1214,6 +1369,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1225,6 +1382,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1236,6 +1395,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1247,6 +1408,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/974 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1708 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1258,6 +1421,8 @@ bookmarks_management: - https://github.com/mozilla-mobile/fenix/issues/3174 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3724 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1271,6 +1436,8 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/issues/977 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1697 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1282,6 +1449,8 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/issues/977 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1697 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1293,6 +1462,8 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/issues/977 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1697 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1311,6 +1482,8 @@ activation: - https://bugzilla.mozilla.org/1501822 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1707#issuecomment-486972209 + data_sensitivity: + - highly_sensitive notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1326,6 +1499,8 @@ activation: - https://bugzilla.mozilla.org/1538011 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/1707#issuecomment-486972209 + data_sensitivity: + - highly_sensitive notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1341,6 +1516,8 @@ qr_scanner: - https://github.com/mozilla-mobile/fenix/issues/1857 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2524#issuecomment-492739967 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1353,6 +1530,8 @@ qr_scanner: - https://github.com/mozilla-mobile/fenix/issues/1857 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2524#issuecomment-492739967 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1365,6 +1544,8 @@ qr_scanner: - https://github.com/mozilla-mobile/fenix/issues/1857 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2524#issuecomment-492739967 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1377,6 +1558,8 @@ qr_scanner: - https://github.com/mozilla-mobile/fenix/issues/1857 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2524#issuecomment-492739967 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1393,6 +1576,8 @@ error_page: - https://github.com/mozilla-mobile/fenix/issues/1242 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2491#issuecomment-492414486 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1406,6 +1591,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1417,6 +1604,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1429,6 +1618,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/9834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9835#pullrequestreview-398641844 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1440,6 +1631,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/9834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9835#pullrequestreview-398641844 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1452,6 +1645,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1464,6 +1659,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1475,6 +1672,9 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/4971 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1487,6 +1687,9 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/4971 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1499,6 +1702,9 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/4971 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1511,6 +1717,9 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/4971 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1523,6 +1732,9 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/4971 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1534,6 +1746,8 @@ sync_auth: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1547,6 +1761,8 @@ sync_account: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1558,6 +1774,8 @@ sync_account: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1569,6 +1787,8 @@ sync_account: - https://github.com/mozilla-mobile/fenix/issues/1190 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1580,6 +1800,8 @@ sync_account: - https://github.com/mozilla-mobile/fenix/issues/4908 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5106 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1591,6 +1813,8 @@ sync_account: - https://github.com/mozilla-mobile/fenix/issues/4908 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5106 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1604,6 +1828,8 @@ history: - https://github.com/mozilla-mobile/fenix/issues/2362 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3940 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1615,6 +1841,8 @@ history: - https://github.com/mozilla-mobile/fenix/issues/2362 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3940 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1626,6 +1854,8 @@ history: - https://github.com/mozilla-mobile/fenix/issues/2362 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3940 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1637,6 +1867,8 @@ history: - https://github.com/mozilla-mobile/fenix/issues/2362 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3940 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1648,6 +1880,8 @@ history: - https://github.com/mozilla-mobile/fenix/issues/2362 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3940 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1664,6 +1898,8 @@ tip: - https://github.com/mozilla-mobile/fenix/issues/9328 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9836 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1678,6 +1914,8 @@ tip: - https://github.com/mozilla-mobile/fenix/issues/9328 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9836 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1692,6 +1930,8 @@ tip: - https://github.com/mozilla-mobile/fenix/issues/9328 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9836 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1705,6 +1945,8 @@ reader_mode: - https://github.com/mozilla-mobile/fenix/issues/2267 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3941 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1716,6 +1958,8 @@ reader_mode: - https://github.com/mozilla-mobile/fenix/issues/2267 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3941 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1727,6 +1971,8 @@ reader_mode: - https://github.com/mozilla-mobile/fenix/issues/2267 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4328 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1738,6 +1984,8 @@ reader_mode: - https://github.com/mozilla-mobile/fenix/issues/2267 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3941 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1751,6 +1999,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1762,6 +2012,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1773,6 +2025,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1784,6 +2038,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1795,6 +2051,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1806,6 +2064,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1817,6 +2077,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1828,6 +2090,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1839,6 +2103,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1851,6 +2117,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1863,6 +2131,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1875,6 +2145,8 @@ tabs_tray: - https://github.com/mozilla-mobile/fenix/issues/11273 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12036 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1888,6 +2160,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1899,6 +2174,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1910,6 +2188,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1921,6 +2202,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1932,6 +2216,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1943,6 +2230,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1959,6 +2249,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1975,6 +2268,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1987,6 +2283,9 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/3935 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -1998,6 +2297,8 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4358 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2009,6 +2310,8 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4358 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2022,6 +2325,8 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4358 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2038,6 +2343,8 @@ collections: - https://github.com/mozilla-mobile/fenix/issues/969 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4539 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2052,6 +2359,8 @@ search_widget: - https://github.com/mozilla-mobile/fenix/issues/4457 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4714 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2063,6 +2372,8 @@ search_widget: - https://github.com/mozilla-mobile/fenix/issues/4457 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4714 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2076,6 +2387,8 @@ search_widget_cfr: - https://github.com/mozilla-mobile/fenix/issues/9488 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10958 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2087,6 +2400,8 @@ search_widget_cfr: - https://github.com/mozilla-mobile/fenix/issues/9488 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10958 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2098,6 +2413,8 @@ search_widget_cfr: - https://github.com/mozilla-mobile/fenix/issues/9488 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10958 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2110,6 +2427,8 @@ search_widget_cfr: - https://github.com/mozilla-mobile/fenix/issues/9488 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10958 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2124,6 +2443,8 @@ private_browsing_mode: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2136,6 +2457,8 @@ private_browsing_mode: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2147,6 +2470,8 @@ private_browsing_mode: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2158,6 +2483,8 @@ private_browsing_mode: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2170,6 +2497,8 @@ private_browsing_mode: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/4968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2184,6 +2513,8 @@ contextual_hint.tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/9625 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11923 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2197,6 +2528,8 @@ contextual_hint.tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/9625 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11923 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2209,6 +2542,8 @@ contextual_hint.tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/9625 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11923 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2221,6 +2556,8 @@ contextual_hint.tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/9625 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11923 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2235,6 +2572,8 @@ tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/5312 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2246,6 +2585,8 @@ tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/5312 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2257,6 +2598,8 @@ tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/5312 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2269,6 +2612,8 @@ tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/5312 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2280,6 +2625,8 @@ tracking_protection: - https://github.com/mozilla-mobile/fenix/issues/5312 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2297,6 +2644,8 @@ tracking_protection: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188 - https://github.com/mozilla-mobile/fenix/pull/11383 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2310,6 +2659,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2322,6 +2673,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2334,6 +2687,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2346,6 +2701,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2358,6 +2715,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2370,6 +2729,8 @@ private_browsing_shortcut: - https://github.com/mozilla-mobile/fenix/issues/4658 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5194 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2383,6 +2744,8 @@ tab: - https://github.com/mozilla-mobile/fenix/issues/5197 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5266 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2396,6 +2759,8 @@ tab: - https://github.com/mozilla-mobile/fenix/issues/5197 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5266 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2409,6 +2774,8 @@ media_notification: - https://github.com/mozilla-mobile/fenix/issues/5197 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5520 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2420,6 +2787,8 @@ media_notification: - https://github.com/mozilla-mobile/fenix/issues/5197 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/5520 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2433,6 +2802,8 @@ media_state: - https://github.com/mozilla-mobile/fenix/issues/5705 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6463 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2444,6 +2815,8 @@ media_state: - https://github.com/mozilla-mobile/fenix/issues/5705 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6463 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2455,6 +2828,8 @@ media_state: - https://github.com/mozilla-mobile/fenix/issues/5705 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6463 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2468,6 +2843,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/5586 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6352 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2479,6 +2856,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/5586 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6352 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2490,6 +2869,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/5586 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6352 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2501,6 +2882,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/5586 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6352 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2517,6 +2900,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/5586 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/7767 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2528,6 +2913,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/10173 data_reviews: - https://github.com/mozilla-mobile/fenix/issues/11208 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2539,6 +2926,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/10173 data_reviews: - https://github.com/mozilla-mobile/fenix/issues/11208 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2550,6 +2939,8 @@ logins: - https://github.com/mozilla-mobile/fenix/issues/10173 data_reviews: - https://github.com/mozilla-mobile/fenix/issues/11208 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2563,6 +2954,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2574,6 +2967,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2585,6 +2980,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2597,6 +2994,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2608,6 +3007,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2619,6 +3020,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2631,6 +3034,8 @@ download_notification: - https://github.com/mozilla-mobile/fenix/issues/5583 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6554 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2644,6 +3049,8 @@ user_specified_search_engines: - https://github.com/mozilla-mobile/fenix/issues/5884 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6918 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2658,6 +3065,8 @@ user_specified_search_engines: - https://github.com/mozilla-mobile/fenix/issues/7881 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6918 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2671,6 +3080,9 @@ search_suggestions: - https://github.com/mozilla-mobile/fenix/issues/6070 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/6746 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2684,6 +3096,8 @@ voice_search: - https://github.com/mozilla-mobile/fenix/issues/10465 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10785 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2697,6 +3111,8 @@ top_sites: - https://github.com/mozilla-mobile/fenix/issues/8125 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10752 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2708,6 +3124,8 @@ top_sites: - https://github.com/mozilla-mobile/fenix/issues/6757 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/7523 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2719,6 +3137,8 @@ top_sites: - https://github.com/mozilla-mobile/fenix/issues/6757 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/7523 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2730,6 +3150,8 @@ top_sites: - https://github.com/mozilla-mobile/fenix/issues/6757 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/7523 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2743,6 +3165,8 @@ about_page: - https://github.com/mozilla-mobile/fenix/issues/6834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8047 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2754,6 +3178,8 @@ about_page: - https://github.com/mozilla-mobile/fenix/issues/6834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8047 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2765,6 +3191,8 @@ about_page: - https://github.com/mozilla-mobile/fenix/issues/6834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8047 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2776,6 +3204,8 @@ about_page: - https://github.com/mozilla-mobile/fenix/issues/6834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8047 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2787,6 +3217,8 @@ about_page: - https://github.com/mozilla-mobile/fenix/issues/6834 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8047 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2805,6 +3237,8 @@ app_theme: - https://github.com/mozilla-mobile/fenix/issues/7289 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/7968 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2818,6 +3252,8 @@ pocket: - https://github.com/mozilla-mobile/fenix/issues/8126 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8098 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2832,6 +3268,8 @@ pocket: - https://github.com/mozilla-mobile/fenix/issues/8126 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8098 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2847,6 +3285,9 @@ first_session: - https://github.com/mozilla-mobile/fenix/issues/7295 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2860,6 +3301,9 @@ first_session: - https://github.com/mozilla-mobile/fenix/issues/7295 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2873,6 +3317,9 @@ first_session: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586480836 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2886,6 +3333,9 @@ first_session: - https://github.com/mozilla-mobile/fenix/issues/7295 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2901,6 +3351,9 @@ first_session: - https://github.com/mozilla-mobile/fenix/issues/7295 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2917,6 +3370,8 @@ browser.search: - https://github.com/mozilla-mobile/fenix/issues/6558 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10112 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2931,6 +3386,8 @@ browser.search: - https://github.com/mozilla-mobile/fenix/issues/6558 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10112 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2944,6 +3401,8 @@ browser.search: - https://github.com/mozilla-mobile/fenix/issues/6557 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10167 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2957,6 +3416,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/6174 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8318 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2972,6 +3433,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/6174 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8318 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2985,6 +3448,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/6174 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8318 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -2998,6 +3463,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/6174 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/8318 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -3011,6 +3478,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/8920 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11080 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -3024,6 +3493,8 @@ addons: - https://github.com/mozilla-mobile/fenix/issues/8920 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11080 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2020-10-01" @@ -3048,6 +3519,8 @@ startup.timeline: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 + data_sensitivity: + - technical notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -3064,6 +3537,8 @@ startup.timeline: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 + data_sensitivity: + - technical notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -3080,6 +3555,8 @@ startup.timeline: - https://github.com/mozilla-mobile/fenix/issues/10434 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10481 + data_sensitivity: + - technical notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -3096,6 +3573,8 @@ startup.timeline: - https://github.com/mozilla-mobile/fenix/issues/8803 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 + data_sensitivity: + - technical notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com @@ -3113,6 +3592,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3128,6 +3610,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3143,6 +3628,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3158,6 +3646,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3173,6 +3664,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3188,6 +3682,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3203,6 +3700,9 @@ perf.awesomebar: - https://github.com/mozilla-mobile/android-components/issues/4992 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - gkruglov@mozilla.com @@ -3216,6 +3716,8 @@ autoplay: - https://github.com/mozilla-mobile/fenix/issues/11579 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13041#issuecomment-665777411 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -3233,6 +3735,8 @@ autoplay: - https://github.com/mozilla-mobile/fenix/issues/11579 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/13041#issuecomment-665777411 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com expires: "2021-02-01" @@ -3251,6 +3755,9 @@ storage.stats: - https://github.com/mozilla-mobile/fenix/issues/12802 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12876#issuecomment-666770732 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - perf-android-fe@mozilla.com @@ -3272,6 +3779,9 @@ storage.stats: - https://github.com/mozilla-mobile/fenix/issues/12802 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12876#issuecomment-666770732 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - perf-android-fe@mozilla.com @@ -3290,6 +3800,9 @@ storage.stats: - https://github.com/mozilla-mobile/fenix/issues/12802 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12876#issuecomment-666770732 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - perf-android-fe@mozilla.com @@ -3310,6 +3823,9 @@ storage.stats: - https://github.com/mozilla-mobile/fenix/issues/12802 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/12876#issuecomment-666770732 + data_sensitivity: + - technical + - interaction notification_emails: - fenix-core@mozilla.com - perf-android-fe@mozilla.com @@ -3325,6 +3841,8 @@ progressive_web_app: - https://github.com/mozilla-mobile/fenix/issues/10261 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11859 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -3337,6 +3855,8 @@ progressive_web_app: - https://github.com/mozilla-mobile/fenix/issues/10261 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11859 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -3353,6 +3873,8 @@ progressive_web_app: - https://github.com/mozilla-mobile/fenix/issues/10261 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11859 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com @@ -3369,6 +3891,8 @@ progressive_web_app: - https://github.com/mozilla-mobile/fenix/issues/10261 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/11859 + data_sensitivity: + - interaction notification_emails: - fenix-core@mozilla.com - erichards@mozilla.com From a6481cc8978db01dcbf253c46c04a70daf75f085 Mon Sep 17 00:00:00 2001 From: Mozilla L10n Automation Bot Date: Tue, 18 Aug 2020 00:14:06 +0000 Subject: [PATCH 2/9] Import l10n. --- app/src/main/res/values-kab/strings.xml | 2 ++ app/src/main/res/values-ko/strings.xml | 48 ++++++++++++------------- app/src/main/res/values-nl/strings.xml | 2 ++ 3 files changed, 28 insertions(+), 24 deletions(-) diff --git a/app/src/main/res/values-kab/strings.xml b/app/src/main/res/values-kab/strings.xml index db2edf695..82e05af33 100644 --- a/app/src/main/res/values-kab/strings.xml +++ b/app/src/main/res/values-kab/strings.xml @@ -306,6 +306,8 @@ Tiktiwin tigejdanin yuzzlen ur nṣeḥḥi ara Ldi iseɣwan deg isnasen + + Amsefrak n usider azɣaray Izegrar diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml index f3974fac7..1e8c7fded 100644 --- a/app/src/main/res/values-ko/strings.xml +++ b/app/src/main/res/values-ko/strings.xml @@ -30,16 +30,16 @@ %1$d개 선택됨 - 새 컬렉션 추가 + 새 모음집 추가 이름 - 컬렉션 선택 + 모음집 선택 다중 선택 모드 종료 - 선택한 탭을 컬렉션에 저장 + 선택한 탭을 모음집에 저장 %1$s 선택됨 @@ -49,7 +49,7 @@ 다중 선택 모드 종료됨 - 다중 선택 모드로 전환됨, 컬렉션에 저장할 탭을 선택하세요 + 다중 선택 모드로 전환됨, 모음집에 저장할 탭을 선택하세요 선택됨 @@ -137,7 +137,7 @@ 새 탭 - 컬렉션에 저장 + 모음집에 저장 공유 @@ -497,7 +497,7 @@ 탭 열기 - 컬렉션에 저장 + 모음집에 저장 모든 탭 공유 @@ -509,7 +509,7 @@ 탭 모드 전환 - 컬렉션에서 탭 삭제 + 모음집에서 탭 삭제 탭 닫기 @@ -521,7 +521,7 @@ 탭 공유 - 탭을 컬렉션에 저장 + 탭을 모음집에 저장 탭 메뉴 @@ -536,11 +536,11 @@ 현재 세션 이미지 - 컬렉션에 저장 + 모음집에 저장 - 컬렉션 삭제 + 모음집 삭제 - 컬렉션 이름 변경 + 모음집 이름 변경 열린 탭 @@ -751,25 +751,25 @@ - 컬렉션 + 모음집 - 컬렉션 메뉴 + 모음집 메뉴 - 중요한 것들을 모으세요 + 중요한 것들 수집하기 - 나중에 빠르게 액세스 할 수 있도록 유사한 검색, 사이트 및 탭을 그룹화하세요. + 나중에 빠르게 접근할 수 있도록 유사한 검색, 사이트 및 탭을 모아 보세요. 탭 선택 - 컬렉션 선택 + 모음집 선택 - 컬렉션 이름 + 모음집 이름 - 새 컬렉션 추가 + 새 모음집 추가 모두 선택 @@ -790,7 +790,7 @@ 탭이 저장되었습니다! - 컬렉션 저장됨! + 모음집 저장됨! 탭이 저장되었습니다! @@ -804,7 +804,7 @@ 보기 - 컬렉션 %d개 + 모음집 %d개 @@ -864,10 +864,10 @@ 제공: - 컬렉션 삭제됨 + 모음집 삭제됨 - 컬렉션 이름 변경됨 + 모음집 이름 변경됨 탭 삭제됨 @@ -904,9 +904,9 @@ %1$s 파일을 삭제하시겠습니까? - 이 탭을 삭제하면 전체 컬렉션이 삭제됩니다. 언제든지 새 컬렉션을 만들 수 있습니다. + 이 탭을 삭제하면 전체 모음집이 삭제됩니다. 언제든지 새 모음집을 만들 수 있습니다. - %1$s 컬렉션을 삭제하시겠습니까? + %1$s 모음집을 삭제하시겠습니까? 삭제 diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index 071f252b1..573324abf 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -40,6 +40,8 @@ Geselecteerde tabbladen in collectie opslaan %1$s geselecteerd + + Selectie %1$s ongedaan gemaakt Geselecteerd From 2743c37b40788e67ef6813fd8af412e1eb36987b Mon Sep 17 00:00:00 2001 From: Gilbert Gilb's Date: Thu, 13 Aug 2020 01:09:59 +0200 Subject: [PATCH 3/9] Add custom Activity to show libraries licenses. As Google's library for showing licences isn't open-source, this commit reimplements its main Activity. This is in prevision to having an OSS flavor of fenix. We chose to not introduce dependencies to third-party libraries such as AboutLibraries for now, and we'll stick to using Google's gradle plugin for the dependencies extraction. Fixes #7584 See also #162 --- app/build.gradle | 1 - app/src/main/AndroidManifest.xml | 9 +- .../fenix/settings/about/AboutFragment.kt | 10 +- .../settings/about/AboutLibrariesActivity.kt | 120 ++++++++++++++++++ .../res/layout/about_libraries_activity.xml | 25 ++++ .../about/AboutLibrariesActivityTest.kt | 45 +++++++ buildSrc/src/main/java/Dependencies.kt | 2 - 7 files changed, 194 insertions(+), 18 deletions(-) create mode 100644 app/src/main/java/org/mozilla/fenix/settings/about/AboutLibrariesActivity.kt create mode 100644 app/src/main/res/layout/about_libraries_activity.xml create mode 100644 app/src/test/java/org/mozilla/fenix/settings/about/AboutLibrariesActivityTest.kt diff --git a/app/build.gradle b/app/build.gradle index 2035810be..0fc4e940c 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -330,7 +330,6 @@ dependencies { implementation Deps.androidx_coordinatorlayout implementation Deps.sentry - implementation Deps.osslicenses_library implementation Deps.leanplum_core implementation Deps.leanplum_fcm diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 825889326..554e11126 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -228,13 +228,8 @@ - - - + diff --git a/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt index ece022c02..3fd152943 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt @@ -13,7 +13,6 @@ import android.view.ViewGroup import androidx.core.content.pm.PackageInfoCompat import androidx.fragment.app.Fragment import androidx.recyclerview.widget.DividerItemDecoration -import com.google.android.gms.oss.licenses.OssLicensesMenuActivity import kotlinx.android.synthetic.main.fragment_about.* import org.mozilla.fenix.BrowserDirection import org.mozilla.fenix.BuildConfig @@ -168,13 +167,8 @@ class AboutFragment : Fragment(), AboutPageListener { } private fun openLibrariesPage() { - startActivity(Intent(context, OssLicensesMenuActivity::class.java)) - OssLicensesMenuActivity.setActivityTitle( - getString( - R.string.open_source_licenses_title, - appName - ) - ) + val intent = Intent(requireContext(), AboutLibrariesActivity::class.java) + startActivity(intent) } override fun onAboutItemClicked(item: AboutItem) { diff --git a/app/src/main/java/org/mozilla/fenix/settings/about/AboutLibrariesActivity.kt b/app/src/main/java/org/mozilla/fenix/settings/about/AboutLibrariesActivity.kt new file mode 100644 index 000000000..bf69fb2f3 --- /dev/null +++ b/app/src/main/java/org/mozilla/fenix/settings/about/AboutLibrariesActivity.kt @@ -0,0 +1,120 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package org.mozilla.fenix.settings.about + +import android.graphics.Typeface +import android.os.Bundle +import android.text.util.Linkify +import android.widget.ArrayAdapter +import android.widget.ListView +import android.widget.TextView +import androidx.appcompat.app.AlertDialog +import androidx.appcompat.app.AppCompatActivity +import org.mozilla.fenix.R +import java.nio.charset.Charset +import java.util.Locale + +/** + * Displays the licenses of all the libraries used by Fenix. + * + * This is a re-implementation of play-services-oss-licenses library. + * We can't use the official implementation in the OSS flavor of Fenix + * because it is proprietary and closed-source. + * + * There are popular FLOSS alternatives to Google's plugin and library + * such as AboutLibraries (https://github.com/mikepenz/AboutLibraries) + * but we considered the risk of introducing such third-party dependency + * to Fenix too high. Therefore, we use Google's gradle plugin to + * extract the dependencies and their licenses, and this activity + * to show the extracted licenses to the end-user. + */ +class AboutLibrariesActivity : AppCompatActivity() { + override fun onCreate(savedInstanceState: Bundle?) { + super.onCreate(savedInstanceState) + + val appName = getString(R.string.app_name) + title = getString(R.string.open_source_licenses_title, appName) + setContentView(R.layout.about_libraries_activity) + + setSupportActionBar(findViewById(R.id.toolbar)) + supportActionBar?.setDisplayHomeAsUpEnabled(true) + supportActionBar?.setDisplayShowHomeEnabled(true) + + setupLibrariesListView() + } + + override fun onSupportNavigateUp(): Boolean { + onBackPressed() + return true + } + + private fun setupLibrariesListView() { + val libraries = parseLibraries() + val listView = findViewById(R.id.about_libraries_listview) + listView.adapter = ArrayAdapter(this, android.R.layout.simple_list_item_1, libraries) + listView.setOnItemClickListener { _, _, position, _ -> + showLicenseDialog(libraries[position]) + } + } + + private fun parseLibraries(): List { + /* + The gradle plugin "oss-licenses-plugin" creates two "raw" resources: + + - third_party_licenses which is the binary concatenation of all the licenses text for + all the libraries. License texts can either be an URL to a license file or just the + raw text of the license. + + - third_party_licenses_metadata which contains one dependency per line formatted in + the following way: "[start_offset]:[length] [name]" + + [start_offset] : first byte in third_party_licenses that contains the license + text for this library. + [length] : length of the license text for this library in + third_party_licenses. + [name] : either the name of the library, or its artifact name. + + See https://github.com/google/play-services-plugins/tree/master/oss-licenses-plugin + */ + val licensesData = resources + .openRawResource(R.raw.third_party_licenses) + .readBytes() + val licensesMetadataReader = resources + .openRawResource(R.raw.third_party_license_metadata) + .bufferedReader() + + return licensesMetadataReader.use { reader -> reader.readLines() }.map { line -> + val (section, name) = line.split(" ", limit = 2) + val (startOffset, length) = section.split(":", limit = 2).map(String::toInt) + val licenseData = licensesData.sliceArray(startOffset until startOffset + length) + val licenseText = licenseData.toString(Charset.forName("UTF-8")) + LibraryItem(name, licenseText) + }.sortedBy { item -> item.name.toLowerCase(Locale.ROOT) } + } + + private fun showLicenseDialog(libraryItem: LibraryItem) { + val dialog = AlertDialog.Builder(this) + .setTitle(libraryItem.name) + .setMessage(libraryItem.license) + .create() + dialog.show() + + val textView = dialog.findViewById(android.R.id.message)!! + Linkify.addLinks(textView, Linkify.ALL) + textView.linksClickable = true + textView.textSize = LICENSE_TEXT_SIZE + textView.typeface = Typeface.MONOSPACE + } + + companion object { + private const val LICENSE_TEXT_SIZE = 10F + } +} + +private class LibraryItem(val name: String, val license: String) { + override fun toString(): String { + return name + } +} diff --git a/app/src/main/res/layout/about_libraries_activity.xml b/app/src/main/res/layout/about_libraries_activity.xml new file mode 100644 index 000000000..bf23bb437 --- /dev/null +++ b/app/src/main/res/layout/about_libraries_activity.xml @@ -0,0 +1,25 @@ + + + + + + + diff --git a/app/src/test/java/org/mozilla/fenix/settings/about/AboutLibrariesActivityTest.kt b/app/src/test/java/org/mozilla/fenix/settings/about/AboutLibrariesActivityTest.kt new file mode 100644 index 000000000..140dc44ae --- /dev/null +++ b/app/src/test/java/org/mozilla/fenix/settings/about/AboutLibrariesActivityTest.kt @@ -0,0 +1,45 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package org.mozilla.fenix.settings.about + +import android.widget.ListView +import android.widget.TextView +import org.junit.Assert.assertTrue +import org.junit.Test +import org.junit.runner.RunWith +import org.mozilla.fenix.R +import org.mozilla.fenix.helpers.FenixRobolectricTestRunner +import org.robolectric.Robolectric +import org.robolectric.Shadows.shadowOf +import org.robolectric.shadows.ShadowAlertDialog + +@RunWith(FenixRobolectricTestRunner::class) +class AboutLibrariesActivityTest { + @Test + fun `activity should display licenses`() { + val activity = Robolectric.buildActivity(AboutLibrariesActivity::class.java).create().get() + val listView = activity.findViewById(R.id.about_libraries_listview) + + assertTrue(0 < listView.count) + } + + @Test + fun `item click should open license dialog`() { + val activity = Robolectric.buildActivity(AboutLibrariesActivity::class.java).create().get() + + val listView = activity.findViewById(R.id.about_libraries_listview) + val listViewShadow = shadowOf(listView) + listViewShadow.clickFirstItemContainingText("org.mozilla.geckoview:geckoview") + + val alertDialogShadow = ShadowAlertDialog.getLatestDialog() + assertTrue(alertDialogShadow.isShowing) + + val alertDialogText = alertDialogShadow + .findViewById(android.R.id.message) + .text + .toString() + assertTrue(alertDialogText.contains("MPL")) + } +} diff --git a/buildSrc/src/main/java/Dependencies.kt b/buildSrc/src/main/java/Dependencies.kt index 876e537dd..40933b3c0 100644 --- a/buildSrc/src/main/java/Dependencies.kt +++ b/buildSrc/src/main/java/Dependencies.kt @@ -10,7 +10,6 @@ object Versions { const val leakcanary = "2.4" const val leanplum = "5.4.0" const val osslicenses_plugin = "0.9.5" - const val osslicenses_library = "17.0.0" const val detekt = "1.9.1" const val androidx_appcompat = "1.2.0-rc01" @@ -59,7 +58,6 @@ object Deps { const val allopen = "org.jetbrains.kotlin:kotlin-allopen:${Versions.kotlin}" const val osslicenses_plugin = "com.google.android.gms:oss-licenses-plugin:${Versions.osslicenses_plugin}" - const val osslicenses_library = "com.google.android.gms:play-services-oss-licenses:${Versions.osslicenses_library}" const val mozilla_concept_engine = "org.mozilla.components:concept-engine:${Versions.mozilla_android_components}" const val mozilla_concept_menu = "org.mozilla.components:concept-menu:${Versions.mozilla_android_components}" From c119070e213ac2f835967f045d13bca36db972b9 Mon Sep 17 00:00:00 2001 From: Kainalu Hagiwara Date: Mon, 10 Aug 2020 16:25:07 -0700 Subject: [PATCH 4/9] For #13030 - Use material design animation values for swipe to switch tabs. --- app/build.gradle | 1 - .../fenix/browser/ToolbarGestureHandler.kt | 135 ++++++++---------- buildSrc/src/main/java/Dependencies.kt | 2 - 3 files changed, 56 insertions(+), 82 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 0fc4e940c..5055bc680 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -428,7 +428,6 @@ dependencies { implementation Deps.androidx_lifecycle_viewmodel implementation Deps.androidx_core implementation Deps.androidx_core_ktx - implementation Deps.androidx_dynamic_animation implementation Deps.androidx_transition implementation Deps.androidx_work_ktx implementation Deps.google_material diff --git a/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt b/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt index cd507391b..a7bfe9d4d 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt @@ -6,19 +6,19 @@ package org.mozilla.fenix.browser import android.animation.Animator import android.animation.AnimatorListenerAdapter +import android.animation.ValueAnimator import android.app.Activity import android.graphics.PointF import android.graphics.Rect -import android.util.TypedValue import android.view.View import android.view.ViewConfiguration import androidx.annotation.Dimension import androidx.annotation.Dimension.DP +import androidx.core.animation.doOnEnd import androidx.core.graphics.contains import androidx.core.graphics.toPoint import androidx.core.view.isVisible -import androidx.dynamicanimation.animation.DynamicAnimation -import androidx.dynamicanimation.animation.FlingAnimation +import androidx.interpolator.view.animation.LinearOutSlowInInterpolator import mozilla.components.browser.session.Session import mozilla.components.browser.session.SessionManager import mozilla.components.support.ktx.android.util.dpToPx @@ -61,11 +61,6 @@ class ToolbarGestureHandler( private val touchSlop = ViewConfiguration.get(activity).scaledTouchSlop private val minimumFlingVelocity = ViewConfiguration.get(activity).scaledMinimumFlingVelocity - private val defaultVelocity = TypedValue.applyDimension( - TypedValue.COMPLEX_UNIT_DIP, - MINIMUM_ANIMATION_VELOCITY, - activity.resources.displayMetrics - ) private var gestureDirection = GestureDirection.LEFT_TO_RIGHT @@ -143,25 +138,12 @@ class ToolbarGestureHandler( ) { val destination = getDestination() if (destination is Destination.Tab && isGestureComplete(velocityX)) { - animateToNextTab(velocityX, destination.session) + animateToNextTab(destination.session) } else { animateCanceledGesture(velocityX) } } - private fun createFlingAnimation( - view: View, - minValue: Float, - maxValue: Float, - startVelocity: Float - ): FlingAnimation = - FlingAnimation(view, DynamicAnimation.TRANSLATION_X).apply { - setMinValue(minValue) - setMaxValue(maxValue) - setStartVelocity(startVelocity) - friction = ViewConfiguration.getScrollFriction() - } - private fun getDestination(): Destination { val isLtr = activity.resources.configuration.layoutDirection == View.LAYOUT_DIRECTION_LTR val currentSession = sessionManager.selectedSession ?: return Destination.None @@ -234,73 +216,59 @@ class ToolbarGestureHandler( abs(velocityX) >= minimumFlingVelocity) } - private fun getVelocityFromFling(velocityX: Float): Float { - return max(abs(velocityX), defaultVelocity) + private fun getAnimator(finalContextX: Float, duration: Long): ValueAnimator { + return ValueAnimator.ofFloat(contentLayout.translationX, finalContextX).apply { + this.duration = duration + this.interpolator = LinearOutSlowInInterpolator() + addUpdateListener { animator -> + val value = animator.animatedValue as Float + contentLayout.translationX = value + tabPreview.translationX = when (gestureDirection) { + GestureDirection.RIGHT_TO_LEFT -> value + windowWidth + previewOffset + GestureDirection.LEFT_TO_RIGHT -> value - windowWidth - previewOffset + } + } + } } - private fun animateToNextTab(velocityX: Float, session: Session) { + private fun animateToNextTab(session: Session) { val browserFinalXCoordinate: Float = when (gestureDirection) { GestureDirection.RIGHT_TO_LEFT -> -windowWidth.toFloat() - previewOffset GestureDirection.LEFT_TO_RIGHT -> windowWidth.toFloat() + previewOffset } - val animationVelocity = when (gestureDirection) { - GestureDirection.RIGHT_TO_LEFT -> -getVelocityFromFling(velocityX) - GestureDirection.LEFT_TO_RIGHT -> getVelocityFromFling(velocityX) - } // Finish animating the contentLayout off screen and tabPreview on screen - createFlingAnimation( - view = contentLayout, - minValue = min(0f, browserFinalXCoordinate), - maxValue = max(0f, browserFinalXCoordinate), - startVelocity = animationVelocity - ).addUpdateListener { _, value, _ -> - tabPreview.translationX = when (gestureDirection) { - GestureDirection.RIGHT_TO_LEFT -> value + windowWidth + previewOffset - GestureDirection.LEFT_TO_RIGHT -> value - windowWidth - previewOffset - } - }.addEndListener { _, _, _, _ -> - contentLayout.translationX = 0f - sessionManager.select(session) + getAnimator(browserFinalXCoordinate, FINISHED_GESTURE_ANIMATION_DURATION).apply { + doOnEnd { + contentLayout.translationX = 0f + sessionManager.select(session) - // Fade out the tab preview to prevent flickering - val shortAnimationDuration = - activity.resources.getInteger(android.R.integer.config_shortAnimTime) - tabPreview.animate() - .alpha(0f) - .setDuration(shortAnimationDuration.toLong()) - .setListener(object : AnimatorListenerAdapter() { - override fun onAnimationEnd(animation: Animator?) { - tabPreview.isVisible = false - } - }) + // Fade out the tab preview to prevent flickering + val shortAnimationDuration = + activity.resources.getInteger(android.R.integer.config_shortAnimTime) + tabPreview.animate() + .alpha(0f) + .setDuration(shortAnimationDuration.toLong()) + .setListener(object : AnimatorListenerAdapter() { + override fun onAnimationEnd(animation: Animator?) { + tabPreview.isVisible = false + } + }) + } }.start() } - private fun animateCanceledGesture(gestureVelocity: Float) { - val velocity = if (getDestination() is Destination.None) { - defaultVelocity + private fun animateCanceledGesture(velocityX: Float) { + val duration = if (abs(velocityX) >= minimumFlingVelocity) { + CANCELED_FLING_ANIMATION_DURATION } else { - getVelocityFromFling(gestureVelocity) - }.let { v -> - when (gestureDirection) { - GestureDirection.RIGHT_TO_LEFT -> v - GestureDirection.LEFT_TO_RIGHT -> -v - } + CANCELED_GESTURE_ANIMATION_DURATION } - createFlingAnimation( - view = contentLayout, - minValue = min(0f, contentLayout.translationX), - maxValue = max(0f, contentLayout.translationX), - startVelocity = velocity - ).addUpdateListener { _, value, _ -> - tabPreview.translationX = when (gestureDirection) { - GestureDirection.RIGHT_TO_LEFT -> value + windowWidth + previewOffset - GestureDirection.LEFT_TO_RIGHT -> value - windowWidth - previewOffset + getAnimator(0f, duration).apply { + doOnEnd { + tabPreview.isVisible = false } - }.addEndListener { _, _, _, _ -> - tabPreview.isVisible = false }.start() } @@ -336,16 +304,25 @@ class ToolbarGestureHandler( */ private const val OVERSCROLL_HIDE_PERCENT = 0.20 - /** - * The speed of the fling animation (in dp per second). - */ - @Dimension(unit = DP) - private const val MINIMUM_ANIMATION_VELOCITY = 1500f - /** * The size of the gap between the tab preview and content layout. */ @Dimension(unit = DP) private const val PREVIEW_OFFSET = 48 + + /** + * Animation duration when switching to another tab + */ + private const val FINISHED_GESTURE_ANIMATION_DURATION = 250L + + /** + * Animation duration gesture is canceled due to the swipe not being far enough + */ + private const val CANCELED_GESTURE_ANIMATION_DURATION = 200L + + /** + * Animation duration gesture is canceled due to a swipe in the opposite direction + */ + private const val CANCELED_FLING_ANIMATION_DURATION = 150L } } diff --git a/buildSrc/src/main/java/Dependencies.kt b/buildSrc/src/main/java/Dependencies.kt index 40933b3c0..8ba27fd3e 100644 --- a/buildSrc/src/main/java/Dependencies.kt +++ b/buildSrc/src/main/java/Dependencies.kt @@ -27,7 +27,6 @@ object Versions { const val androidx_paging = "2.1.0" const val androidx_transition = "1.3.0" const val androidx_work = "2.2.0" - const val androidx_dynamic_animation = "1.0.0" const val google_material = "1.1.0" const val google_flexbox = "2.0.1" @@ -172,7 +171,6 @@ object Deps { const val androidx_recyclerview = "androidx.recyclerview:recyclerview:${Versions.androidx_recyclerview}" const val androidx_core = "androidx.core:core:${Versions.androidx_core}" const val androidx_core_ktx = "androidx.core:core-ktx:${Versions.androidx_core}" - const val androidx_dynamic_animation = "androidx.dynamicanimation:dynamicanimation:${Versions.androidx_dynamic_animation}" const val androidx_transition = "androidx.transition:transition:${Versions.androidx_transition}" const val androidx_work_ktx = "androidx.work:work-runtime-ktx:${Versions.androidx_work}" const val androidx_work_testing = "androidx.work:work-testing:${Versions.androidx_work}" From 5f5caa4720c1f18637ba12946204e8f162da7b83 Mon Sep 17 00:00:00 2001 From: MickeyMoz Date: Tue, 18 Aug 2020 14:08:31 +0000 Subject: [PATCH 5/9] Update Android Components version to 54.0.20200818130156. --- buildSrc/src/main/java/AndroidComponents.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildSrc/src/main/java/AndroidComponents.kt b/buildSrc/src/main/java/AndroidComponents.kt index c429e7980..1560073ba 100644 --- a/buildSrc/src/main/java/AndroidComponents.kt +++ b/buildSrc/src/main/java/AndroidComponents.kt @@ -3,5 +3,5 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ object AndroidComponents { - const val VERSION = "54.0.20200814130102" + const val VERSION = "54.0.20200818130156" } From cd729b39e537d89dfd7918eca6bdd394b02ba301 Mon Sep 17 00:00:00 2001 From: TejaswiKarasani Date: Tue, 18 Aug 2020 22:33:47 +0530 Subject: [PATCH 6/9] For #112,#145: Verify Search engine can be changed temporarily using Search engine (#13259) --- .../java/org/mozilla/fenix/ui/SmokeTest.kt | 66 +++++++++++++++++ .../mozilla/fenix/ui/robots/BrowserRobot.kt | 2 + .../fenix/ui/robots/NavigationToolbarRobot.kt | 6 ++ .../mozilla/fenix/ui/robots/SearchRobot.kt | 71 +++++++++++++++++++ 4 files changed, 145 insertions(+) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt index 802a3a22b..7423f9050 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt @@ -16,6 +16,7 @@ import org.junit.Test import org.mozilla.fenix.helpers.AndroidAssetDispatcher import org.mozilla.fenix.helpers.HomeActivityTestRule import org.mozilla.fenix.helpers.TestAssetHelper +import org.mozilla.fenix.ui.robots.clickUrlbar import org.mozilla.fenix.ui.robots.homeScreen import org.mozilla.fenix.ui.robots.navigationToolbar @@ -254,4 +255,69 @@ class SmokeTest { } } } + + @Test + fun verifySearchEngineCanBeChangedTemporarilyUsingShortcuts() { + val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) + + homeScreen { + }.openSearch { + verifyKeyboardVisibility() + clickSearchEngineButton() + verifySearchEngineList() + changeDefaultSearchEngine("Amazon.com") + verifySearchEngineIcon("Amazon.com") + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openTabDrawer { + // Changing search engine to Bing + }.openHomeScreen { + }.openSearch { + clickSearchEngineButton() + mDevice.waitForIdle() + changeDefaultSearchEngine("Bing") + verifySearchEngineIcon("Bing") + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openTabDrawer { + // Changing search engine to DuckDuckGo + }.openHomeScreen { + }.openSearch { + clickSearchEngineButton() + mDevice.waitForIdle() + changeDefaultSearchEngine("DuckDuckGo") + verifySearchEngineIcon("DuckDuckGo") + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openTabDrawer { + // Changing search engine to Twitter + }.openHomeScreen { + }.openSearch { + clickSearchEngineButton() + mDevice.waitForIdle() + changeDefaultSearchEngine("Twitter") + verifySearchEngineIcon("Twitter") + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openTabDrawer { + // Changing search engine to Wikipedia + }.openHomeScreen { + }.openSearch { + clickSearchEngineButton() + changeDefaultSearchEngine("Wikipedia") + verifySearchEngineIcon("Wikipedia") + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openTabDrawer { + // Checking whether the next search will be with default or not + }.openHomeScreen { + }.openSearch { + }.goToSearchEngine { + }.enterURLAndEnterToBrowser(defaultWebPage.url) { + }.openNavigationToolbar { + clickUrlbar { + verifyDefaultSearchEngine("Google") + } + } + } } diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt index 5d6732cce..e07d7ba8c 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt @@ -12,12 +12,14 @@ import android.net.Uri import androidx.test.espresso.Espresso.onView import androidx.test.espresso.Espresso.pressBack import androidx.test.espresso.action.ViewActions +import androidx.test.espresso.action.ViewActions.click import androidx.test.espresso.assertion.ViewAssertions.matches import androidx.test.espresso.intent.Intents import androidx.test.espresso.intent.matcher.BundleMatchers import androidx.test.espresso.intent.matcher.IntentMatchers import androidx.test.espresso.matcher.RootMatchers.isDialog import androidx.test.espresso.matcher.ViewMatchers +import androidx.test.espresso.matcher.ViewMatchers.withContentDescription import androidx.test.espresso.matcher.ViewMatchers.Visibility import androidx.test.espresso.matcher.ViewMatchers.isCompletelyDisplayed import androidx.test.espresso.matcher.ViewMatchers.isDisplayed diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt index 556007c8f..5d37179ed 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt @@ -239,6 +239,12 @@ fun navigationToolbar(interact: NavigationToolbarRobot.() -> Unit): NavigationTo return NavigationToolbarRobot.Transition() } +fun clickUrlbar(interact: SearchRobot.() -> Unit): SearchRobot.Transition { + urlBar().click() + SearchRobot().interact() + return SearchRobot.Transition() +} + private fun assertSuggestionsAreEqualTo(suggestionSize: Int, searchTerm: String) { mDevice.waitForIdle() awesomeBar().perform(typeText(searchTerm)) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt index 8bfe0f56e..d8dc47fab 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt @@ -6,6 +6,7 @@ package org.mozilla.fenix.ui.robots +import android.widget.ToggleButton import androidx.recyclerview.widget.RecyclerView import androidx.test.espresso.Espresso.onView import androidx.test.espresso.ViewInteraction @@ -16,7 +17,9 @@ import androidx.test.espresso.action.ViewActions.typeText import androidx.test.espresso.assertion.ViewAssertions.matches import androidx.test.espresso.contrib.RecyclerViewActions import androidx.test.espresso.matcher.ViewMatchers +import androidx.test.espresso.matcher.ViewMatchers.Visibility import androidx.test.espresso.matcher.ViewMatchers.withContentDescription +import androidx.test.espresso.matcher.ViewMatchers.withEffectiveVisibility import androidx.test.espresso.matcher.ViewMatchers.withId import androidx.test.espresso.matcher.ViewMatchers.withText import androidx.test.platform.app.InstrumentationRegistry @@ -28,8 +31,11 @@ import androidx.test.uiautomator.Until import org.hamcrest.CoreMatchers.allOf import org.hamcrest.CoreMatchers.startsWith import org.hamcrest.Matchers +import org.junit.Assert.assertEquals import org.mozilla.fenix.R import org.mozilla.fenix.helpers.TestAssetHelper +import org.mozilla.fenix.helpers.TestAssetHelper.waitingTime +import org.mozilla.fenix.helpers.click import org.mozilla.fenix.helpers.ext.waitNotNull /** @@ -47,6 +53,24 @@ class SearchRobot { fun verifySearchSettings() = assertSearchSettings() fun verifySearchBarEmpty() = assertSearchBarEmpty() + fun verifyKeyboardVisibility() = assertKeyboardVisibility(isExpectedToBeVisible = true) + fun verifySearchEngineList() = assertSearchEngineList() + fun verifySearchEngineIcon(expectedText: String) { + onView(withContentDescription(expectedText)) + } + fun verifyDefaultSearchEngine(expectedText: String) = assertDefaultSearchEngine(expectedText) + + fun changeDefaultSearchEngine(searchEngineName: String) = + selectDefaultSearchEngine(searchEngineName) + + fun clickSearchEngineButton() { + val searchEngineButton = mDevice.findObject(UiSelector() + .instance(1) + .className(ToggleButton::class.java)) + searchEngineButton.waitForExists(waitingTime) + searchEngineButton.click() + } + fun clickScanButton() { scanButton().perform(click()) } @@ -106,6 +130,11 @@ class SearchRobot { BrowserRobot().interact() return BrowserRobot.Transition() } + + fun goToSearchEngine(interact: NavigationToolbarRobot.() -> Unit): NavigationToolbarRobot.Transition { + NavigationToolbarRobot().interact() + return NavigationToolbarRobot.Transition() + } } } @@ -178,4 +207,46 @@ fun searchScreen(interact: SearchRobot.() -> Unit): SearchRobot.Transition { return SearchRobot.Transition() } +private fun assertKeyboardVisibility(isExpectedToBeVisible: Boolean) = { + mDevice.waitNotNull( + Until.findObject( + By.text("Search Engine") + ), waitingTime + ) + assertEquals( + isExpectedToBeVisible, + UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()) + .executeShellCommand("dumpsys input_method | grep mInputShown") + .contains("mInputShown=true") + ) +} + +private fun assertSearchEngineList() { + onView(withId(R.id.mozac_browser_toolbar_edit_icon)).click() + onView(withText("Google")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + onView(withText("Amazon.com")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + onView(withText("Bing")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + onView(withText("DuckDuckGo")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + onView(withText("Twitter")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + onView(withText("Wikipedia")) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) +} + +private fun selectDefaultSearchEngine(searchEngine: String) { + onView(withId(R.id.mozac_browser_toolbar_edit_icon)).click() + onView(withText(searchEngine)) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) + .perform(click()) +} + +private fun assertDefaultSearchEngine(expectedText: String) { + onView(allOf(withId(R.id.mozac_browser_toolbar_edit_icon), withContentDescription(expectedText))) + .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) +} + private fun goBackButton() = onView(allOf(withContentDescription("Navigate up"))) From d49ca515f48fad3817572d1bf235dda6de59c57e Mon Sep 17 00:00:00 2001 From: Kainalu Hagiwara Date: Fri, 14 Aug 2020 10:22:00 -0700 Subject: [PATCH 7/9] For #13330 - Remove feature flag for swipe to switch tabs. --- .../java/org/mozilla/fenix/FeatureFlags.kt | 5 -- .../fenix/browser/BaseBrowserFragment.kt | 6 +- .../mozilla/fenix/browser/BrowserFragment.kt | 22 ++--- .../res/layout/browser_gesture_wrapper.xml | 19 ---- app/src/main/res/layout/fragment_browser.xml | 87 +++++++++++-------- 5 files changed, 59 insertions(+), 80 deletions(-) delete mode 100644 app/src/main/res/layout/browser_gesture_wrapper.xml diff --git a/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt b/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt index da2c235cf..c3b944f2e 100644 --- a/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt +++ b/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt @@ -29,11 +29,6 @@ object FeatureFlags { */ val tabTray = Config.channel.isNightlyOrDebug - /** - * Enables gestures on the browser chrome that depend on a [SwipeGestureLayout] - */ - val browserChromeGestures = Config.channel.isNightlyOrDebug - /** * Enables viewing tab history */ diff --git a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt index cfad14859..1acc0e059 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt @@ -168,11 +168,7 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session require(arguments != null) customTabSessionId = arguments?.getString(EXTRA_SESSION_ID) - val view = if (FeatureFlags.browserChromeGestures) { - inflater.inflate(R.layout.browser_gesture_wrapper, container, false) - } else { - inflater.inflate(R.layout.fragment_browser, container, false) - } + val view = inflater.inflate(R.layout.fragment_browser, container, false) val activity = activity as HomeActivity activity.themeManager.applyStatusBarTheme(activity) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 9163d8ab5..797a5c34d 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -15,7 +15,6 @@ import androidx.core.content.ContextCompat import androidx.lifecycle.Observer import androidx.navigation.fragment.findNavController import com.google.android.material.snackbar.Snackbar -import kotlinx.android.synthetic.main.browser_gesture_wrapper.* import kotlinx.android.synthetic.main.fragment_browser.* import kotlinx.android.synthetic.main.fragment_browser.view.* import kotlinx.coroutines.ExperimentalCoroutinesApi @@ -32,7 +31,6 @@ import mozilla.components.feature.tab.collections.TabCollection import mozilla.components.feature.tabs.WindowFeature import mozilla.components.support.base.feature.UserInteractionHandler import mozilla.components.support.base.feature.ViewBoundFeatureWrapper -import org.mozilla.fenix.FeatureFlags import org.mozilla.fenix.R import org.mozilla.fenix.addons.runIfFragmentIsAttached import org.mozilla.fenix.components.FenixSnackbar @@ -77,19 +75,15 @@ class BrowserFragment : BaseBrowserFragment(), UserInteractionHandler { val components = context.components return super.initializeUI(view)?.also { - // We need to wrap this whole thing in an if here because gestureLayout will not exist - // if the feature flag is off - if (FeatureFlags.browserChromeGestures) { - gestureLayout.addGestureListener( - ToolbarGestureHandler( - activity = requireActivity(), - contentLayout = browserLayout, - tabPreview = tabPreview, - toolbarLayout = browserToolbarView.view, - sessionManager = components.core.sessionManager - ) + gestureLayout.addGestureListener( + ToolbarGestureHandler( + activity = requireActivity(), + contentLayout = browserLayout, + tabPreview = tabPreview, + toolbarLayout = browserToolbarView.view, + sessionManager = components.core.sessionManager ) - } + ) val readerModeAction = BrowserToolbar.ToggleButton( diff --git a/app/src/main/res/layout/browser_gesture_wrapper.xml b/app/src/main/res/layout/browser_gesture_wrapper.xml deleted file mode 100644 index 4de55e61f..000000000 --- a/app/src/main/res/layout/browser_gesture_wrapper.xml +++ /dev/null @@ -1,19 +0,0 @@ - - - - - - - - diff --git a/app/src/main/res/layout/fragment_browser.xml b/app/src/main/res/layout/fragment_browser.xml index 328f9bedd..5ed490ea6 100644 --- a/app/src/main/res/layout/fragment_browser.xml +++ b/app/src/main/res/layout/fragment_browser.xml @@ -1,53 +1,66 @@ - - - + android:layout_height="match_parent"> - + tools:context="browser.BrowserFragment"> - + + + + + + + + - + - + + - - - - - - + From 446f1d678eeb3024a99fce8a49023d7f5bd8c531 Mon Sep 17 00:00:00 2001 From: Jeff Boek Date: Mon, 3 Aug 2020 13:40:11 -0700 Subject: [PATCH 8/9] For #11656 - Adds addon user attributes to leanplum --- .../org/mozilla/fenix/components/metrics/MetricController.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt index 1694d89f0..6f2234948 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt @@ -5,6 +5,7 @@ package org.mozilla.fenix.components.metrics import androidx.annotation.VisibleForTesting +import com.leanplum.Leanplum import mozilla.components.browser.awesomebar.facts.BrowserAwesomeBarFacts import mozilla.components.browser.menu.facts.BrowserMenuFacts import mozilla.components.browser.toolbar.facts.ToolbarFacts @@ -193,6 +194,7 @@ internal class ReleaseMetricController( if (installedAddons is List<*>) { Addons.installedAddons.set(installedAddons.map { it.toString() }) Addons.hasInstalledAddons.set(installedAddons.size > 0) + Leanplum.setUserAttributes(mapOf("installed_addons" to installedAddons.size)) } } @@ -200,6 +202,7 @@ internal class ReleaseMetricController( if (enabledAddons is List<*>) { Addons.enabledAddons.set(enabledAddons.map { it.toString() }) Addons.hasEnabledAddons.set(enabledAddons.size > 0) + Leanplum.setUserAttributes(mapOf("enabled_addons" to enabledAddons.size)) } } From b8de7079a963efb140ed318d876f23a17a0e3d9e Mon Sep 17 00:00:00 2001 From: Jeff Boek Date: Thu, 13 Aug 2020 12:41:02 -0700 Subject: [PATCH 9/9] For #11656 - Adds docs for new leanplum attributes --- docs/mma.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/mma.md b/docs/mma.md index 4db6157ae..ab632d0f1 100644 --- a/docs/mma.md +++ b/docs/mma.md @@ -159,6 +159,16 @@ User Attributes A boolean indicating that this is a Fenix installation #8208 + + `installed_addons` + A boolean indicating that there are addons installed + #13233 + + + `enabled_addons` + A boolean indicating that there are addons enabled + #13233 + Events