From b7325a3833b68b915f189af15d3421c24acd3816 Mon Sep 17 00:00:00 2001 From: Elise Richards Date: Mon, 27 Jul 2020 17:19:31 -0500 Subject: [PATCH 01/20] For #12571: Rename shortcuts to search engine on search screen (#12839) * Rename shortcuts to search engine on search screen * Remove deprecated pref key * Re-add deprecated string --- .../mozilla/fenix/components/metrics/Metrics.kt | 2 +- .../org/mozilla/fenix/search/SearchFragment.kt | 12 ++++++------ .../settings/search/SearchEngineFragment.kt | 2 +- .../java/org/mozilla/fenix/utils/Settings.kt | 2 +- app/src/main/res/layout/fragment_search.xml | 16 ++++++++-------- app/src/main/res/values/preference_keys.xml | 3 +-- app/src/main/res/values/strings.xml | 12 +++++++----- app/src/main/res/values/styles.xml | 2 +- app/src/main/res/xml/search_preferences.xml | 2 +- 9 files changed, 27 insertions(+), 26 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt index 77a08ce20..22ec2e328 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt @@ -236,7 +236,7 @@ sealed class Event { context.getString(R.string.pref_key_search_bookmarks), context.getString(R.string.pref_key_search_browsing_history), context.getString(R.string.pref_key_show_clipboard_suggestions), - context.getString(R.string.pref_key_show_search_shortcuts), + context.getString(R.string.pref_key_show_search_engine_shortcuts), context.getString(R.string.pref_key_open_links_in_a_private_tab), context.getString(R.string.pref_key_sync_logins), context.getString(R.string.pref_key_sync_bookmarks), diff --git a/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt b/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt index f0ca9bff3..fb706bcda 100644 --- a/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt @@ -268,7 +268,7 @@ class SearchFragment : Fragment(), UserInteractionHandler { qrFeature.get()?.scan(R.id.container) } - view.search_shortcuts_button.setOnClickListener { + view.search_engines_shortcut_button.setOnClickListener { searchInteractor.onSearchShortcutsButtonClicked() } @@ -400,7 +400,7 @@ class SearchFragment : Fragment(), UserInteractionHandler { } private fun updateSearchWithLabel(searchState: SearchFragmentState) { - search_with_shortcuts.visibility = + search_engine_shortcut.visibility = if (searchState.showSearchShortcuts) View.VISIBLE else View.GONE } @@ -450,19 +450,19 @@ class SearchFragment : Fragment(), UserInteractionHandler { findViewById(R.id.search_suggestions_onboarding)?.isVisible = state.showSearchSuggestionsHint search_suggestions_onboarding_divider?.isVisible = - search_with_shortcuts.isVisible && state.showSearchSuggestionsHint + search_engine_shortcut.isVisible && state.showSearchSuggestionsHint } } private fun updateSearchShortcutsIcon(searchState: SearchFragmentState) { view?.apply { - search_shortcuts_button.isVisible = searchState.areShortcutsAvailable + search_engines_shortcut_button.isVisible = searchState.areShortcutsAvailable val showShortcuts = searchState.showSearchShortcuts - search_shortcuts_button.isChecked = showShortcuts + search_engines_shortcut_button.isChecked = showShortcuts val color = if (showShortcuts) R.attr.contrastText else R.attr.primaryText - search_shortcuts_button.compoundDrawables[0]?.setTint( + search_engines_shortcut_button.compoundDrawables[0]?.setTint( requireContext().getColorFromAttr(color) ) } diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt index 954e31658..800bf05bc 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt @@ -38,7 +38,7 @@ class SearchEngineFragment : PreferenceFragmentCompat() { } val showSearchShortcuts = - requirePreference(R.string.pref_key_show_search_shortcuts).apply { + requirePreference(R.string.pref_key_show_search_engine_shortcuts).apply { isChecked = context.settings().shouldShowSearchShortcuts } diff --git a/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/app/src/main/java/org/mozilla/fenix/utils/Settings.kt index 180b022a2..defa8901d 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/Settings.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/Settings.kt @@ -305,7 +305,7 @@ class Settings(private val appContext: Context) : PreferencesHolder { ) val shouldShowSearchShortcuts by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_show_search_shortcuts), + appContext.getPreferenceKey(R.string.pref_key_show_search_engine_shortcuts), default = false ) diff --git a/app/src/main/res/layout/fragment_search.xml b/app/src/main/res/layout/fragment_search.xml index ebdc0bc21..9a6e5873b 100644 --- a/app/src/main/res/layout/fragment_search.xml +++ b/app/src/main/res/layout/fragment_search.xml @@ -52,7 +52,7 @@ android:fadingEdgeLength="40dp" android:nestedScrollingEnabled="false" android:requiresFadingEdge="vertical" - app:layout_constraintTop_toBottomOf="@id/search_with_shortcuts" + app:layout_constraintTop_toBottomOf="@id/search_engine_shortcut" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" mozac:awesomeBarDescriptionTextColor="?secondaryText" @@ -139,8 +139,8 @@ app:layout_constraintTop_toBottomOf="@id/fill_link_from_clipboard" /> + tools:text="@string/search_engines_search_with" /> + app:constraint_referenced_ids="fill_link_from_clipboard,search_engine_shortcut,search_suggestions_onboarding" /> @@ -195,10 +195,10 @@ app:drawableStartCompat="@drawable/ic_qr" /> \ No newline at end of file diff --git a/app/src/main/res/values/preference_keys.xml b/app/src/main/res/values/preference_keys.xml index 125190f09..08f64e202 100644 --- a/app/src/main/res/values/preference_keys.xml +++ b/app/src/main/res/values/preference_keys.xml @@ -86,7 +86,7 @@ pref_key_search_engine_list - pref_key_show_search_shortcuts + pref_key_show_search_engine_shortcuts pref_key_show_search_suggestions pref_key_show_clipboard_suggestions pref_key_search_browsing_history @@ -95,7 +95,6 @@ pref_key_show_search_suggestions_in_privateonboarding pref_key_show_voice_search - pref_key_optimize pref_key_show_site_exceptions diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 04601fc28..e14bfecf9 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -167,8 +167,8 @@ Scan - - Search Engine + + Search engine Search engine settings @@ -1456,12 +1456,14 @@ OK, Got It - + Shortcuts Search with - + This time, search with: - + Show search shortcuts + + Search Engine diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index f370730f1..6b675efc7 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -455,7 +455,7 @@ 0dp -