diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/SearchTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/SearchTest.kt index 7a346eb60..3b6a24651 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/SearchTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/SearchTest.kt @@ -67,7 +67,7 @@ class SearchTest { }.openSearch { scrollToSearchEngineSettings() clickSearchEngineSettings() - verifySearchEngineSettings() + verifySearchSettings() } } diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt index a78b40ba8..4e758593d 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt @@ -41,7 +41,7 @@ class SearchRobot { fun verifySearchWithText() = assertSearchWithText() fun verifyDuckDuckGoResults() = assertDuckDuckGoResults() fun verifyDuckDuckGoURL() = assertDuckDuckGoURL() - fun verifySearchEngineSettings() = assertSearchEngineSettings() + fun verifySearchSettings() = assertSearchSettings() fun verifySearchBarEmpty() = assertSearchBarEmpty() fun clickScanButton() { @@ -161,8 +161,8 @@ private fun assertSearchWithText() = onView(allOf(withText("SEARCH WITH"))) .check(matches(ViewMatchers.withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) -private fun assertSearchEngineSettings() = - onView(allOf(withText("Search engine"))) +private fun assertSearchSettings() = + onView(allOf(withText("Default search engine"))) .check(matches(ViewMatchers.withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) private fun assertSearchBarEmpty() = browserToolbarEditView().check(matches(withText(""))) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SearchEngineFragment.kt index c0723d06b..7ca54b6b4 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SearchEngineFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SearchEngineFragment.kt @@ -20,7 +20,7 @@ class SearchEngineFragment : PreferenceFragmentCompat() { override fun onResume() { super.onResume() - (activity as AppCompatActivity).title = getString(R.string.preferences_search_engine) + (activity as AppCompatActivity).title = getString(R.string.preferences_search) (activity as AppCompatActivity).supportActionBar?.show() val searchSuggestionsPreference = diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index c7ff37ce4..a72321415 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -49,7 +49,7 @@ import org.mozilla.fenix.R.string.pref_key_make_default_browser import org.mozilla.fenix.R.string.pref_key_privacy_link import org.mozilla.fenix.R.string.pref_key_rate import org.mozilla.fenix.R.string.pref_key_remote_debugging -import org.mozilla.fenix.R.string.pref_key_search_engine_settings +import org.mozilla.fenix.R.string.pref_key_search_settings import org.mozilla.fenix.R.string.pref_key_sign_in import org.mozilla.fenix.R.string.pref_key_site_permissions import org.mozilla.fenix.R.string.pref_key_theme @@ -124,12 +124,6 @@ class SettingsFragment : PreferenceFragmentCompat(), AccountObserver { findPreference(getPreferenceKey(R.string.pref_key_make_default_browser)) defaultBrowserPreference?.updateSwitch() - val searchEnginePreference = - findPreference(getPreferenceKey(R.string.pref_key_search_engine_settings)) - searchEnginePreference?.summary = context?.let { - requireComponents.search.searchEngineManager.getDefaultSearchEngine(it).name - } - val trackingProtectionPreference = findPreference(getPreferenceKey(R.string.pref_key_tracking_protection_settings)) trackingProtectionPreference?.summary = context?.let { @@ -158,7 +152,7 @@ class SettingsFragment : PreferenceFragmentCompat(), AccountObserver { @Suppress("ComplexMethod", "LongMethod") override fun onPreferenceTreeClick(preference: Preference): Boolean { when (preference.key) { - resources.getString(pref_key_search_engine_settings) -> { + resources.getString(pref_key_search_settings) -> { navigateToSearchEngineSettings() } resources.getString(pref_key_tracking_protection_settings) -> { diff --git a/app/src/main/res/navigation/nav_graph.xml b/app/src/main/res/navigation/nav_graph.xml index 7f0ef039a..a45601494 100644 --- a/app/src/main/res/navigation/nav_graph.xml +++ b/app/src/main/res/navigation/nav_graph.xml @@ -399,7 +399,7 @@ + android:label="@string/preferences_search" /> pref_key_make_default_browser - pref_key_search_engine_settings + pref_key_search_settings pref_key_search_engine pref_key_passwords pref_key_credit_cards_addresses diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b570c217d..b4259a690 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -116,7 +116,9 @@ About - Search engine + Default search engine + + Search Help diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml index 9634ccdb7..af23cba60 100644 --- a/app/src/main/res/xml/preferences.xml +++ b/app/src/main/res/xml/preferences.xml @@ -33,8 +33,8 @@ app:iconSpaceReserved="false"> + android:key="@string/pref_key_search_settings" + android:title="@string/preferences_search" /> - - - - - + + + + + + +