From 4bab49348707110b5fb44248d91c18020dafa49b Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Thu, 2 Jan 2020 09:50:09 -0800 Subject: [PATCH] No issue: remove useless @MenuRes annotation in History Fragment. This annotation was not applied correctly and lint was unable to ensure it was used properly: it declared an error in lint saying so but that error was ignored. I did not know how to apply the annotation - and I felt it had limited utility - so I removed it entirely in order to permit the lint baseline file to be removed (it was the only error). --- .../java/org/mozilla/fenix/library/history/HistoryFragment.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt index d2305e861..59ae207c8 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt @@ -12,7 +12,6 @@ import android.view.MenuInflater import android.view.MenuItem import android.view.View import android.view.ViewGroup -import androidx.annotation.MenuRes import androidx.appcompat.app.AlertDialog import androidx.lifecycle.Observer import androidx.lifecycle.lifecycleScope @@ -126,7 +125,6 @@ class HistoryFragment : LibraryPageFragment(), UserInteractionHandl } override fun onCreateOptionsMenu(menu: Menu, inflater: MenuInflater) { - @MenuRes val menuRes = when (historyStore.state.mode) { HistoryFragmentState.Mode.Normal -> R.menu.library_menu is HistoryFragmentState.Mode.Editing -> R.menu.history_select_multi