From 3c48b3eeca8a53ab16a7525639a4378fceb55c2d Mon Sep 17 00:00:00 2001 From: Emily Kager Date: Thu, 31 Jan 2019 11:33:56 -0800 Subject: [PATCH] Style settings theme, add about category --- app/src/main/AndroidManifest.xml | 2 +- .../java/org/mozilla/fenix/HomeActivity.kt | 12 ++- .../fenix/settings/SettingsFragment.kt | 3 +- app/src/main/res/drawable/ic_about.xml | 13 ++- .../main/res/drawable/ic_accessibility.xml | 3 +- .../main/res/drawable/ic_bookmark_outline.xml | 1 - .../main/res/drawable/ic_data_collection.xml | 1 - app/src/main/res/drawable/ic_feedback.xml | 16 ++-- app/src/main/res/drawable/ic_help.xml | 2 - app/src/main/res/drawable/ic_language.xml | 1 - app/src/main/res/drawable/ic_library.xml | 1 - app/src/main/res/drawable/ic_menu.xml | 1 - app/src/main/res/drawable/ic_new.xml | 1 - app/src/main/res/drawable/ic_permission.xml | 3 +- .../main/res/drawable/ic_private_browsing.xml | 3 +- app/src/main/res/drawable/ic_search.xml | 13 +++ app/src/main/res/drawable/ic_settings.xml | 1 - app/src/main/res/values/strings.xml | 29 +++++-- app/src/main/res/values/styles.xml | 9 ++- app/src/main/res/xml/preferences.xml | 80 ++++++++++++------- buildSrc/src/main/java/Dependencies.kt | 2 +- 21 files changed, 133 insertions(+), 64 deletions(-) create mode 100644 app/src/main/res/drawable/ic_search.xml diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index ba121514b..2fc676ba5 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -49,7 +49,7 @@ android:name=".settings.SettingsActivity" android:label="@string/settings" android:parentActivityName=".HomeActivity" - android:theme="@style/LightAppTheme" /> + android:theme="@style/SettingsAppTheme" /> \ No newline at end of file diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt index 08aabd103..96627667d 100644 --- a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt +++ b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt @@ -18,9 +18,17 @@ class HomeActivity : AppCompatActivity() { setContentView(R.layout.activity_home) } - override fun onCreateView(parent: View?, name: String?, context: Context, attrs: AttributeSet?): View? = + override fun onCreateView( + parent: View?, + name: String, + context: Context, + attrs: AttributeSet + ): View? = when (name) { - EngineView::class.java.name -> components.core.engine.createView(context, attrs).asView() + EngineView::class.java.name -> components.core.engine.createView( + context, + attrs + ).asView() else -> super.onCreateView(parent, name, context, attrs) } } diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index 7ffae300d..7ad4afd61 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -8,6 +8,7 @@ import android.content.Intent import android.os.Bundle import android.provider.Settings import android.widget.Toast +import androidx.preference.Preference import androidx.preference.Preference.OnPreferenceClickListener import androidx.preference.PreferenceFragmentCompat import org.mozilla.fenix.R @@ -37,7 +38,7 @@ class SettingsFragment : PreferenceFragmentCompat() { private fun setupPreferences() { val makeDefaultBrowserKey = context?.getPreferenceKey(pref_key_make_default_browser) - val preferenceMakeDefaultBrowser = findPreference(makeDefaultBrowserKey) + val preferenceMakeDefaultBrowser = findPreference(makeDefaultBrowserKey) preferenceMakeDefaultBrowser.onPreferenceClickListener = getClickListenerForMakeDefaultBrowser() } diff --git a/app/src/main/res/drawable/ic_about.xml b/app/src/main/res/drawable/ic_about.xml index 2f3db2dbe..3c835637e 100644 --- a/app/src/main/res/drawable/ic_about.xml +++ b/app/src/main/res/drawable/ic_about.xml @@ -1,8 +1,13 @@ - - - + + diff --git a/app/src/main/res/drawable/ic_accessibility.xml b/app/src/main/res/drawable/ic_accessibility.xml index b7139743c..254921bb6 100644 --- a/app/src/main/res/drawable/ic_accessibility.xml +++ b/app/src/main/res/drawable/ic_accessibility.xml @@ -9,6 +9,5 @@ android:viewportHeight="24"> + android:fillColor="#0c0c0d" /> diff --git a/app/src/main/res/drawable/ic_bookmark_outline.xml b/app/src/main/res/drawable/ic_bookmark_outline.xml index ae72b31d3..f29b8088a 100644 --- a/app/src/main/res/drawable/ic_bookmark_outline.xml +++ b/app/src/main/res/drawable/ic_bookmark_outline.xml @@ -10,6 +10,5 @@ diff --git a/app/src/main/res/drawable/ic_data_collection.xml b/app/src/main/res/drawable/ic_data_collection.xml index 288a60562..311d2e66f 100644 --- a/app/src/main/res/drawable/ic_data_collection.xml +++ b/app/src/main/res/drawable/ic_data_collection.xml @@ -10,6 +10,5 @@ diff --git a/app/src/main/res/drawable/ic_feedback.xml b/app/src/main/res/drawable/ic_feedback.xml index 92a47e7b7..fbb51a28b 100644 --- a/app/src/main/res/drawable/ic_feedback.xml +++ b/app/src/main/res/drawable/ic_feedback.xml @@ -1,9 +1,15 @@ - - - - + + + diff --git a/app/src/main/res/drawable/ic_help.xml b/app/src/main/res/drawable/ic_help.xml index b18310c22..9d605e7fb 100644 --- a/app/src/main/res/drawable/ic_help.xml +++ b/app/src/main/res/drawable/ic_help.xml @@ -7,11 +7,9 @@ android:viewportWidth="24" android:viewportHeight="24"> diff --git a/app/src/main/res/drawable/ic_language.xml b/app/src/main/res/drawable/ic_language.xml index daa7d0317..3aac2d838 100644 --- a/app/src/main/res/drawable/ic_language.xml +++ b/app/src/main/res/drawable/ic_language.xml @@ -10,6 +10,5 @@ diff --git a/app/src/main/res/drawable/ic_library.xml b/app/src/main/res/drawable/ic_library.xml index 655957841..33784f6a8 100644 --- a/app/src/main/res/drawable/ic_library.xml +++ b/app/src/main/res/drawable/ic_library.xml @@ -7,7 +7,6 @@ android:viewportWidth="24" android:viewportHeight="24"> diff --git a/app/src/main/res/drawable/ic_menu.xml b/app/src/main/res/drawable/ic_menu.xml index 629c5ff01..d37e13986 100644 --- a/app/src/main/res/drawable/ic_menu.xml +++ b/app/src/main/res/drawable/ic_menu.xml @@ -10,6 +10,5 @@ diff --git a/app/src/main/res/drawable/ic_new.xml b/app/src/main/res/drawable/ic_new.xml index d22510087..47aa348a9 100644 --- a/app/src/main/res/drawable/ic_new.xml +++ b/app/src/main/res/drawable/ic_new.xml @@ -7,7 +7,6 @@ android:viewportWidth="24" android:viewportHeight="24"> diff --git a/app/src/main/res/drawable/ic_permission.xml b/app/src/main/res/drawable/ic_permission.xml index eddec9edd..f754db17b 100644 --- a/app/src/main/res/drawable/ic_permission.xml +++ b/app/src/main/res/drawable/ic_permission.xml @@ -9,6 +9,5 @@ android:viewportHeight="24"> + android:fillColor="#0c0c0d" /> diff --git a/app/src/main/res/drawable/ic_private_browsing.xml b/app/src/main/res/drawable/ic_private_browsing.xml index 78121c70c..f3ad44d43 100644 --- a/app/src/main/res/drawable/ic_private_browsing.xml +++ b/app/src/main/res/drawable/ic_private_browsing.xml @@ -9,6 +9,5 @@ android:viewportHeight="24"> + android:fillColor="#0C0C0D" /> diff --git a/app/src/main/res/drawable/ic_search.xml b/app/src/main/res/drawable/ic_search.xml new file mode 100644 index 000000000..afe20e349 --- /dev/null +++ b/app/src/main/res/drawable/ic_search.xml @@ -0,0 +1,13 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_settings.xml b/app/src/main/res/drawable/ic_settings.xml index 010c5a92f..461c9c33b 100644 --- a/app/src/main/res/drawable/ic_settings.xml +++ b/app/src/main/res/drawable/ic_settings.xml @@ -7,7 +7,6 @@ android:viewportWidth="24" android:viewportHeight="24"> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 863ef10bf..cb920706e 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -1,5 +1,4 @@ - - @@ -24,12 +23,33 @@ Scan Shortcuts + + Settings + + Fill link from Clipboard + + Basics + + About + Search engine + + Help + + + Rate on Play Store + + + Give feedback + + + About Fenix + Passwords @@ -53,9 +73,4 @@ Data choices - - - Settings - - Fill link from Clipboard diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index eec633bc4..db15db8cd 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -2,7 +2,7 @@ - + + +