blallo
/
fenix
1
0
Fork 0
Code Releases Activity

removed auto play permissions while determining isVisible for WebsitePermissionsState

master
apoorv9990 2020-05-04 18:12:51 -07:00 committed by Emily Kager
parent 97704bfdbd
commit 3469eeed9e
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsFragmentStore.kt
View File

@ -145,8 +145,7 @@ class QuickSettingsFragmentStore(
val autoplayInaudiblePermission = val autoplayInaudiblePermission =
PhoneFeature.AUTOPLAY_INAUDIBLE.toWebsitePermission(context, permissions, settings) PhoneFeature.AUTOPLAY_INAUDIBLE.toWebsitePermission(context, permissions, settings)
val shouldBeVisible = cameraPermission.isVisible || microphonePermission.isVisible || val shouldBeVisible = cameraPermission.isVisible || microphonePermission.isVisible ||
notificationPermission.isVisible || locationPermission.isVisible || notificationPermission.isVisible || locationPermission.isVisible
autoplayAudiblePermission.isVisible || autoplayInaudiblePermission.isVisible
return WebsitePermissionsState( return WebsitePermissionsState(
shouldBeVisible, cameraPermission, microphonePermission, shouldBeVisible, cameraPermission, microphonePermission,

7
app/src/main/java/org/mozilla/fenix/settings/quicksettings/WebsitePermissionsView.kt
View File

@ -55,12 +55,7 @@ class WebsitePermissionsView(
* @param state [WebsitePermissionsState] to be rendered. * @param state [WebsitePermissionsState] to be rendered.
*/ */
fun update(state: WebsitePermissionsState) { fun update(state: WebsitePermissionsState) {
val isAnyPermissionVisible = state.camera.isVisible || state.location.isVisible || if (state.isVisible) {
state.microphone.isVisible || state.notification.isVisible
// Can not use state.isVisible because we are not handling the audio permissions here right
// now. If we add more permissions below we should update isAnyPermissionVisible too
if (isAnyPermissionVisible) {
interactor.onPermissionsShown() interactor.onPermissionsShown()
} }