From 332b4c4da538f07a9a68b3ce4b0c411825c4d541 Mon Sep 17 00:00:00 2001 From: Jeff Boek Date: Mon, 10 Jun 2019 15:04:30 -0700 Subject: [PATCH] For #3278 - makes the string a constant --- .../fenix/settings/RadioSearchEngineListPreference.kt | 1 - .../mozilla/fenix/settings/SearchEngineListPreference.kt | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/RadioSearchEngineListPreference.kt b/app/src/main/java/org/mozilla/fenix/settings/RadioSearchEngineListPreference.kt index 410a3508b..2c59312e4 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/RadioSearchEngineListPreference.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/RadioSearchEngineListPreference.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.settings import android.content.Context import android.util.AttributeSet import android.widget.CompoundButton -import androidx.preference.PreferenceViewHolder import mozilla.components.browser.search.SearchEngine import org.mozilla.fenix.R import org.mozilla.fenix.ext.components diff --git a/app/src/main/java/org/mozilla/fenix/settings/SearchEngineListPreference.kt b/app/src/main/java/org/mozilla/fenix/settings/SearchEngineListPreference.kt index 41bad8958..05336b42c 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SearchEngineListPreference.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SearchEngineListPreference.kt @@ -80,7 +80,7 @@ abstract class SearchEngineListPreference : Preference, CompoundButton.OnChecked // https://github.com/mozilla-mobile/android-components/issues/3344 val defaultSearchEngine = context.components.search.searchEngineManager.getDefaultSearchEngine( context, - "." + THIS_IS_A_HACK_FIX_ME ) val selectedSearchEngine = @@ -153,4 +153,8 @@ abstract class SearchEngineListPreference : Preference, CompoundButton.OnChecked } } } + + companion object { + private const val THIS_IS_A_HACK_FIX_ME = "." + } }