diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt index 6cdf2235b..5df5129bc 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt @@ -93,7 +93,7 @@ class AddSearchEngineFragment : Fragment(), CompoundButton.OnCheckedChangeListen availableEngines.forEachIndexed(setupSearchEngineItem) - val engineItem = makeCustomButton(layoutInflater) + val engineItem = makeCustomButton(layoutInflater, res = resources) engineItem.id = CUSTOM_INDEX engineItem.radio_button.isChecked = selectedIndex == CUSTOM_INDEX engineViews.add(engineItem) @@ -250,11 +250,12 @@ class AddSearchEngineFragment : Fragment(), CompoundButton.OnCheckedChangeListen toggleCustomForm(selectedIndex == -1) } - private fun makeCustomButton(layoutInflater: LayoutInflater): View { + private fun makeCustomButton(layoutInflater: LayoutInflater, res: Resources): View { val wrapper = layoutInflater .inflate(R.layout.custom_search_engine_radio_button, null) as ConstraintLayout wrapper.setOnClickListener { wrapper.radio_button.isChecked = true } wrapper.radio_button.setOnCheckedChangeListener(this) + wrapper.minHeight = res.getDimensionPixelSize(R.dimen.radio_button_preference_height) return wrapper } @@ -280,6 +281,7 @@ class AddSearchEngineFragment : Fragment(), CompoundButton.OnCheckedChangeListen engineIcon.setBounds(0, 0, iconSize, iconSize) wrapper.engine_icon.setImageDrawable(engineIcon) wrapper.overflow_menu.visibility = View.GONE + wrapper.minHeight = res.getDimensionPixelSize(R.dimen.radio_button_preference_height) return wrapper } diff --git a/app/src/main/res/layout/custom_search_engine_radio_button.xml b/app/src/main/res/layout/custom_search_engine_radio_button.xml index 53eaada56..8ece2dbfe 100644 --- a/app/src/main/res/layout/custom_search_engine_radio_button.xml +++ b/app/src/main/res/layout/custom_search_engine_radio_button.xml @@ -20,7 +20,8 @@ android:textAppearance="?android:attr/textAppearanceListItem" android:layout_marginStart="@dimen/search_bar_search_engine_icon_padding" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toTopOf="parent" /> + app:layout_constraintTop_toTopOf="parent" + app:layout_constraintBottom_toBottomOf="parent"/>