From 314bee2abd49b31b0911454a5a72ad6992cbe020 Mon Sep 17 00:00:00 2001 From: mcarare <“mihai.carare.dev@gmail.com”> Date: Mon, 24 Feb 2020 15:20:25 +0200 Subject: [PATCH] For #8627: Add proper content description to ETP card clickable areas --- .../OnboardingTrackingProtectionViewHolder.kt | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt index de8a248f4..bdfc6a474 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt @@ -60,16 +60,32 @@ class OnboardingTrackingProtectionViewHolder(view: View) : RecyclerView.ViewHold updateTrackingProtectionPolicy() } - view.clickable_region_standard.setOnClickListener { - standardTrackingProtection.performClick() + view.clickable_region_standard.apply { + setOnClickListener { + standardTrackingProtection.performClick() + } + val standardTitle = view.context.getString( + R.string.onboarding_tracking_protection_standard_button + ) + val standardSummary = view.context.getString( + R.string.onboarding_tracking_protection_standard_button_description + ) + contentDescription = "$standardTitle. $standardSummary" } strictTrackingProtection.onClickListener { updateTrackingProtectionPolicy() } - view.clickable_region_strict.setOnClickListener { - strictTrackingProtection.performClick() + view.clickable_region_strict.apply { + setOnClickListener { + strictTrackingProtection.performClick() + } + val strictTitle = + view.context.getString(R.string.onboarding_tracking_protection_strict_button) + val strictSummary = + view.context.getString(R.string.onboarding_tracking_protection_strict_button_description) + contentDescription = "$strictTitle. $strictSummary" } }