From 2a4aa241950501454680e5e7a7e37f67af2cb29c Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Fri, 6 Dec 2019 15:02:25 -0800 Subject: [PATCH] For perf-frontend-issues#33: Clarify VERBOSE logging motivation. --- .../org/mozilla/fenix/perf/HotStartPerformanceMonitor.kt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/perf/HotStartPerformanceMonitor.kt b/app/src/main/java/org/mozilla/fenix/perf/HotStartPerformanceMonitor.kt index df4e130d8..df8b66746 100644 --- a/app/src/main/java/org/mozilla/fenix/perf/HotStartPerformanceMonitor.kt +++ b/app/src/main/java/org/mozilla/fenix/perf/HotStartPerformanceMonitor.kt @@ -19,11 +19,14 @@ import android.util.Log * to add monitoring code (i.e. the first time our application code is called in onRestart). An * alternative implementation could measure performance from outside the application. * - * To see logs from this class, the user must enable VERBOSE logging for the appropriate tag: + * The logs from this class are not visible to users by default. To see logs from this class, the + * user must enable VERBOSE logging for the appropriate tag: * adb shell setprop log.tag.FenixPerf VERBOSE */ class HotStartPerformanceMonitor( - private val log: (String) -> Unit = { Log.v(Performance.TAG, it) }, // android log to minimize overhead. + // We use VERBOSE logging so that the logs are not visible to users by default. We use the + // Android Log methods to minimize overhead introduced in a-c logging. + private val log: (String) -> Unit = { Log.v(Performance.TAG, it) }, private val getElapsedRealtime: () -> Long = { SystemClock.elapsedRealtime() } ) {