From 2888d66ce0d853ea865754b59a19f411581a1cb4 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 15 Apr 2020 11:13:36 -0700 Subject: [PATCH] For #8803 - review: move forward metric expiration date. We primarily want to determine if this is a problem area for us to investigate rather than a long term measurement to keep so we should set the expiration date accordingly. Furthermore, this code executes before crash reporting is init so it's ideal to remove it sooner rather than later. --- app/metrics.yaml | 6 +++--- docs/metrics.md | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/metrics.yaml b/app/metrics.yaml index bc747c685..0229c384f 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -2007,7 +2007,7 @@ startup.timeline: notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com - expires: "2020-10-01" + expires: "2020-07-15" framework_start_error: send_in_pings: - startup-timeline @@ -2022,7 +2022,7 @@ startup.timeline: notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com - expires: "2020-10-01" + expires: "2020-07-15" clock_ticks_per_second: send_in_pings: - startup-timeline @@ -2037,4 +2037,4 @@ startup.timeline: notification_emails: - perf-android-fe@mozilla.com - mcomella@mozilla.com - expires: "2020-10-01" + expires: "2020-07-15" diff --git a/docs/metrics.md b/docs/metrics.md index 5bf6e2877..06a39b4c6 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -253,9 +253,9 @@ The following metrics are added to the ping: | Name | Type | Description | Data reviews | Extras | Expiration | | --- | --- | --- | --- | --- | --- | -| startup.timeline.clock_ticks_per_second |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The number of clock tick time units that occur in one second on this particular device. This value is expected to be used in conjunction with the `framework_start` metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-10-01 | -| startup.timeline.framework_start |[timespan](https://mozilla.github.io/glean/book/user/metrics/timespan.html) |The duration the Android framework takes to start before letting us run code in `*Application.init`. This is calculated from `appInitTimestamp - processStartTimestamp`. `processStartTimestamp` is derived from the clock tick time unit, which is expected to be less granular than nanoseconds. Therefore, we convert and round our timestamps to clock ticks before computing the difference and convert back to nanoseconds to report. For debugging purposes, `clock_ticks_per_second`, which may vary between devices, is also reported as a metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-10-01 | -| startup.timeline.framework_start_error |[boolean](https://mozilla.github.io/glean/book/user/metrics/boolean.html) |An error when attempting to record `framework_start` - the application init timestamp returned a negative value - which is likely indicative of a bug in the implementation. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-10-01 | +| startup.timeline.clock_ticks_per_second |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The number of clock tick time units that occur in one second on this particular device. This value is expected to be used in conjunction with the `framework_start` metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 | +| startup.timeline.framework_start |[timespan](https://mozilla.github.io/glean/book/user/metrics/timespan.html) |The duration the Android framework takes to start before letting us run code in `*Application.init`. This is calculated from `appInitTimestamp - processStartTimestamp`. `processStartTimestamp` is derived from the clock tick time unit, which is expected to be less granular than nanoseconds. Therefore, we convert and round our timestamps to clock ticks before computing the difference and convert back to nanoseconds to report. For debugging purposes, `clock_ticks_per_second`, which may vary between devices, is also reported as a metric. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 | +| startup.timeline.framework_start_error |[boolean](https://mozilla.github.io/glean/book/user/metrics/boolean.html) |An error when attempting to record `framework_start` - the application init timestamp returned a negative value - which is likely indicative of a bug in the implementation. |[1](https://github.com/mozilla-mobile/fenix/pull/9788#issuecomment-610648980)||2020-07-15 |