blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For issue #8100: Add progress bar to the add-ons manager fragment

master
Arturo Mejia 2020-02-05 16:32:50 -05:00 committed by GitHub
parent be7bd527f6
commit 1fef90721a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
View File

@ -8,6 +8,7 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.view.isVisible
import androidx.fragment.app.Fragment
import androidx.lifecycle.lifecycleScope
import androidx.navigation.Navigation
@ -87,11 +88,16 @@ class AddonsManagementFragment : Fragment(), AddonsManagerAdapterDelegate {
this@AddonsManagementFragment,
addons
)
view.add_ons_progress_bar.isVisible = false
view.add_ons_empty_message.isVisible = false
recyclerView.adapter = adapter
}
} catch (e: AddonManagerException) {
lifecycleScope.launch(Dispatchers.Main) {
showSnackBar(view, getString(R.string.mozac_feature_addons_failed_to_query_add_ons))
view.add_ons_progress_bar.isVisible = false
view.add_ons_empty_message.isVisible = true
}
}
}

19
app/src/main/res/layout/fragment_add_ons_management.xml
View File

@ -21,4 +21,23 @@
android:layout_height="wrap_content"
android:layout_gravity="bottom"
android:visibility="gone" />
<ProgressBar
android:id="@+id/add_ons_progress_bar"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center" />
<TextView
android:id="@+id/add_ons_empty_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="4dp"
android:layout_gravity="center"
android:gravity="center"
android:text="@string/no_add_ons"
android:textColor="?secondaryText"
android:textSize="16sp"
android:visibility="gone"/>
</androidx.coordinatorlayout.widget.CoordinatorLayout>

2
app/src/main/res/values/strings.xml
View File

@ -66,6 +66,8 @@
<string name="browser_menu_edit_bookmark">Edit bookmark</string>
<!-- Browser menu button that sends a user to help articles -->
<string name="browser_menu_addon_manager">Add-ons Manager</string>
<!-- Text displayed when there are no add-ons to be shown -->
<string name="no_add_ons">No add-ons here</string>
<!-- Browser menu button that sends a user to help articles -->
<string name="browser_menu_help">Help</string>
<!-- Browser menu button that sends a to a the what's new article -->