From 1e223a8a5334f99302de8b6906065fef0594472a Mon Sep 17 00:00:00 2001 From: mcarare Date: Mon, 17 Aug 2020 17:41:58 +0300 Subject: [PATCH] For #13761: Add a11y change listener after toolbar is initialised. Also removed it before reference is removed in onDestroy. --- .../java/org/mozilla/fenix/browser/BaseBrowserFragment.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt index 836b4755d..cfad14859 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt @@ -188,6 +188,7 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session final override fun onViewCreated(view: View, savedInstanceState: Bundle?) { browserInitialized = initializeUI(view) != null + requireContext().accessibilityManager.addAccessibilityStateChangeListener(this) } @Suppress("ComplexMethod", "LongMethod") @@ -756,7 +757,6 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session super.onStart() requireComponents.core.sessionManager.register(this, this, autoPause = true) sitePermissionWifiIntegration.get()?.maybeAddWifiConnectedListener() - requireContext().accessibilityManager.addAccessibilityStateChangeListener(this) } @CallSuper @@ -1062,9 +1062,9 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session */ override fun onDestroyView() { super.onDestroyView() + requireContext().accessibilityManager.removeAccessibilityStateChangeListener(this) _browserToolbarView = null _browserInteractor = null - requireContext().accessibilityManager.removeAccessibilityStateChangeListener(this) } companion object {