From 1df9c53b9fc50b50beaa7b37e6e91f5015bf759d Mon Sep 17 00:00:00 2001
From: Emily Kager <emilykager@gmail.com>
Date: Thu, 16 Apr 2020 20:31:25 -0700
Subject: [PATCH] Fix: Set correct height for EditText (#10014)

Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
---
 app/src/main/res/layout/fragment_edit_bookmark.xml | 4 ++--
 app/src/main/res/values/dimens.xml                 | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/src/main/res/layout/fragment_edit_bookmark.xml b/app/src/main/res/layout/fragment_edit_bookmark.xml
index 9f7a6695e..8d8a1df9e 100644
--- a/app/src/main/res/layout/fragment_edit_bookmark.xml
+++ b/app/src/main/res/layout/fragment_edit_bookmark.xml
@@ -36,7 +36,7 @@
     <org.mozilla.fenix.utils.ClearableEditText
         android:id="@+id/bookmarkNameEdit"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/bookmark_edit_text_height"
         android:layout_marginBottom="8dp"
         android:drawablePadding="8dp"
         android:ellipsize="none"
@@ -62,7 +62,7 @@
     <org.mozilla.fenix.utils.ClearableEditText
         android:id="@+id/bookmarkUrlEdit"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/bookmark_edit_text_height"
         android:layout_marginBottom="8dp"
         android:drawablePadding="8dp"
         android:ellipsize="none"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 505f6164d..87176fb86 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -67,6 +67,9 @@
     <!-- ETP Onboarding Popup -->
     <dimen name="etp_onboarding_popup_width">256dp</dimen>
 
+    <!-- Edit  Fragment  -->
+    <dimen name="bookmark_edit_text_height">48dp</dimen>
+
     <!-- Search Fragment -->
     <dimen name="search_fragment_clipboard_item_height">56dp</dimen>
     <dimen name="search_fragment_clipboard_item_horizontal_margin">12dp</dimen>