From 11697c13638da79aabc3a799d7d346c38969c51f Mon Sep 17 00:00:00 2001 From: ekager Date: Tue, 9 Jun 2020 15:12:53 -0400 Subject: [PATCH] For #11390 - Removes redundant session observer init for ETP overlay --- .../org/mozilla/fenix/browser/BrowserFragment.kt | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 33f78afdb..8a1ce8696 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -147,8 +147,7 @@ class BrowserFragment : BaseBrowserFragment(), UserInteractionHandler { ) { browserToolbarView.view } - session?.register(toolbarSessionObserver, this, autoPause = true) - updateEngineBottomMargin() + session?.register(toolbarSessionObserver, viewLifecycleOwner, autoPause = true) if (settings.shouldShowFirstTimePwaFragment) { session?.register( @@ -174,16 +173,6 @@ class BrowserFragment : BaseBrowserFragment(), UserInteractionHandler { } } - private fun updateEngineBottomMargin() { - val toolbarSessionObserver = TrackingProtectionOverlay( - context = requireContext(), - settings = requireContext().settings() - ) { - browserToolbarView.view - } - getSessionById()?.register(toolbarSessionObserver, this, autoPause = true) - } - override fun onResume() { super.onResume() getSessionById()?.let {