diff --git a/app/metrics.yaml b/app/metrics.yaml index 2d996f067..843d7f2f2 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -314,6 +314,17 @@ quick_action_sheet: notification_emails: - fenix-core@mozilla.com expires: "2020-03-01" + open_app_tapped: + type: event + description: > + A user tapped the open in app button + bugs: + - 1195 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/4629 + notification_emails: + - fenix-core@mozilla.com + expires: "2020-03-01" metrics: default_browser: diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index bad50c528..308738239 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -122,6 +122,9 @@ private val Event.wrapper is Event.QuickActionSheetDownloadTapped -> EventWrapper( { QuickActionSheet.downloadTapped.record(it) } ) + is Event.QuickActionSheetOpenInAppTapped -> EventWrapper( + { QuickActionSheet.openAppTapped.record(it) } + ) is Event.OpenedBookmarkInNewTab -> EventWrapper( { BookmarksManagement.openInNewTab.record(it) } ) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt index 14038a591..7c2deaab2 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt @@ -73,6 +73,7 @@ sealed class Event { object QuickActionSheetShareTapped : Event() object QuickActionSheetBookmarkTapped : Event() object QuickActionSheetDownloadTapped : Event() + object QuickActionSheetOpenInAppTapped : Event() object CustomTabsClosed : Event() object CustomTabsActionTapped : Event() object CustomTabsMenuOpened : Event() diff --git a/app/src/main/java/org/mozilla/fenix/quickactionsheet/QuickActionSheetController.kt b/app/src/main/java/org/mozilla/fenix/quickactionsheet/QuickActionSheetController.kt index 9f6b1deb5..746cf3960 100644 --- a/app/src/main/java/org/mozilla/fenix/quickactionsheet/QuickActionSheetController.kt +++ b/app/src/main/java/org/mozilla/fenix/quickactionsheet/QuickActionSheetController.kt @@ -53,6 +53,8 @@ class DefaultQuickActionSheetController( } override fun handleOpenLink() { + context.metrics.track(Event.QuickActionSheetOpenInAppTapped) + val getRedirect = appLinksUseCases.appLinkRedirect val redirect = currentSession.let { getRedirect.invoke(it.url) diff --git a/buildSrc/src/main/java/Dependencies.kt b/buildSrc/src/main/java/Dependencies.kt index 280d66ee6..18459dd6d 100644 --- a/buildSrc/src/main/java/Dependencies.kt +++ b/buildSrc/src/main/java/Dependencies.kt @@ -205,7 +205,7 @@ object Deps { const val robolectric = "org.robolectric:robolectric:${Versions.robolectric}" const val fragment_testing = "androidx.fragment:fragment-testing:${Versions.androidx_fragment}" const val androidx_junit = "androidx.test.ext:junit:${Versions.androidx_test_ext}" - const val androidx_test_core ="androidx.test:core:${Versions.androidx_testing}" + const val androidx_test_core = "androidx.test:core:${Versions.androidx_testing}" const val fenix_megazord = "org.mozilla.appservices:fenix-megazord:${Versions.mozilla_appservices}" const val fenix_megazord_forUnitTests = "org.mozilla.appservices:fenix-megazord-forUnitTests:${Versions.mozilla_appservices}" diff --git a/docs/metrics.md b/docs/metrics.md index a495fb5c1..667e80f70 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -314,6 +314,14 @@ tracking_protection 2020-03-01 + + open_app_tapped + event + A user tapped the open in app button + link + + 2020-03-01 +