From 02a929a926153dbe1dcb2c5f4dac6ccdcb5882bf Mon Sep 17 00:00:00 2001 From: Kainalu Hagiwara Date: Mon, 20 Jul 2020 15:51:43 -0700 Subject: [PATCH] No issue - Suppress new warnings from detekt update --- app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt | 1 + .../fenix/home/sessioncontrol/SessionControlController.kt | 2 +- .../org/mozilla/fenix/library/bookmarks/BookmarkController.kt | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt b/app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt index a555dd8f0..35c87c9b6 100644 --- a/app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt +++ b/app/src/main/java/org/mozilla/fenix/collections/TabDiffUtil.kt @@ -10,6 +10,7 @@ import org.mozilla.fenix.home.Tab /** * Diff callback for comparing tab lists with selected state. */ +@Suppress("LongParameterList") internal class TabDiffUtil( private val old: List, private val new: List, diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt index 2935fd075..2cf7a5471 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt @@ -128,7 +128,7 @@ interface SessionControlController { fun handleCreateCollection() } -@SuppressWarnings("TooManyFunctions", "LargeClass") +@SuppressWarnings("TooManyFunctions", "LargeClass", "LongParameterList") class DefaultSessionControlController( private val activity: HomeActivity, private val engine: Engine, diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt index 1aca89890..f8503653e 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt @@ -47,7 +47,7 @@ interface BookmarkController { fun handleBackPressed() } -@SuppressWarnings("TooManyFunctions") +@SuppressWarnings("TooManyFunctions", "LongParameterList") class DefaultBookmarkController( private val activity: HomeActivity, private val navController: NavController,