From 014de10b29035a718735260132f9aecd16813770 Mon Sep 17 00:00:00 2001 From: Jeff Boek Date: Wed, 15 May 2019 13:13:43 -0700 Subject: [PATCH] Fixes #2533 - Adds the feature flag to the menu item to create a collection --- .../viewholders/TabHeaderViewHolder.kt | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabHeaderViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabHeaderViewHolder.kt index 315530546..c3d8d22ab 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabHeaderViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabHeaderViewHolder.kt @@ -12,6 +12,7 @@ import kotlinx.android.synthetic.main.tab_header.view.* import mozilla.components.browser.menu.BrowserMenu import mozilla.components.browser.menu.BrowserMenuBuilder import mozilla.components.browser.menu.item.SimpleBrowserMenuItem +import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.R import org.mozilla.fenix.home.sessioncontrol.SessionControlAction import org.mozilla.fenix.home.sessioncontrol.TabAction @@ -80,13 +81,20 @@ class TabHeaderViewHolder( context.getString(R.string.tabs_menu_share_tabs) ) { onItemTapped.invoke(Item.Share) - }, - SimpleBrowserMenuItem( - context.getString(R.string.tabs_menu_save_to_collection) - ) { - onItemTapped.invoke(Item.SaveToCollection) } - ) + ).let { + val list = it.toMutableList() + if (BuildConfig.COLLECTIONS_ENABLED) { + list.add( + SimpleBrowserMenuItem( + context.getString(R.string.tabs_menu_save_to_collection) + ) { + onItemTapped.invoke(Item.SaveToCollection) + } + ) + } + list + } } }