blallo
/
Signal-Android
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rename 'userAgent' to 'signalAgent'. 

This wasn't actually being used in the User-Agent header. Instead, it
was used as the value for an X-Signal-Agent header. To avoid confusion,
I'm renaming this.
master
Greyson Parrelli 2020-01-23 11:28:17 -05:00
parent f1147c10ee
commit a31da7616d
8 changed files with 34 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/build.gradle
View File

@ -227,7 +227,7 @@ android {
buildConfigField "String", "SIGNAL_KEY_BACKUP_URL", "\"https://api.backup.signal.org\"" buildConfigField "String", "SIGNAL_KEY_BACKUP_URL", "\"https://api.backup.signal.org\""
buildConfigField "String", "CONTENT_PROXY_HOST", "\"contentproxy.signal.org\"" buildConfigField "String", "CONTENT_PROXY_HOST", "\"contentproxy.signal.org\""
buildConfigField "int", "CONTENT_PROXY_PORT", "443" buildConfigField "int", "CONTENT_PROXY_PORT", "443"
buildConfigField "String", "USER_AGENT", "\"OWA\"" buildConfigField "String", "SIGNAL_AGENT", "\"OWA\""
buildConfigField "boolean", "DEV_BUILD", "false" buildConfigField "boolean", "DEV_BUILD", "false"
buildConfigField "String", "MRENCLAVE", "\"cd6cfc342937b23b1bdd3bbf9721aa5615ac9ff50a75c5527d441cd3276826c9\"" buildConfigField "String", "MRENCLAVE", "\"cd6cfc342937b23b1bdd3bbf9721aa5615ac9ff50a75c5527d441cd3276826c9\""
buildConfigField "String", "KEY_BACKUP_ENCLAVE_NAME", "\"\"" buildConfigField "String", "KEY_BACKUP_ENCLAVE_NAME", "\"\""

6
app/src/main/java/org/thoughtcrime/securesms/dependencies/ApplicationDependencyProvider.java
View File

@ -57,7 +57,7 @@ public class ApplicationDependencyProvider implements ApplicationDependencies.Pr
public @NonNull SignalServiceAccountManager provideSignalServiceAccountManager() { public @NonNull SignalServiceAccountManager provideSignalServiceAccountManager() {
return new SignalServiceAccountManager(networkAccess.getConfiguration(context), return new SignalServiceAccountManager(networkAccess.getConfiguration(context),
new DynamicCredentialsProvider(context), new DynamicCredentialsProvider(context),
BuildConfig.USER_AGENT); BuildConfig.SIGNAL_AGENT);
} }
@Override @Override
@ -65,7 +65,7 @@ public class ApplicationDependencyProvider implements ApplicationDependencies.Pr
return new SignalServiceMessageSender(networkAccess.getConfiguration(context), return new SignalServiceMessageSender(networkAccess.getConfiguration(context),
new DynamicCredentialsProvider(context), new DynamicCredentialsProvider(context),
new SignalProtocolStoreImpl(context), new SignalProtocolStoreImpl(context),
BuildConfig.USER_AGENT, BuildConfig.SIGNAL_AGENT,
TextSecurePreferences.isMultiDevice(context), TextSecurePreferences.isMultiDevice(context),
Optional.fromNullable(IncomingMessageObserver.getPipe()), Optional.fromNullable(IncomingMessageObserver.getPipe()),
Optional.fromNullable(IncomingMessageObserver.getUnidentifiedPipe()), Optional.fromNullable(IncomingMessageObserver.getUnidentifiedPipe()),
@ -78,7 +78,7 @@ public class ApplicationDependencyProvider implements ApplicationDependencies.Pr
: new UptimeSleepTimer(); : new UptimeSleepTimer();
return new SignalServiceMessageReceiver(networkAccess.getConfiguration(context), return new SignalServiceMessageReceiver(networkAccess.getConfiguration(context),
new DynamicCredentialsProvider(context), new DynamicCredentialsProvider(context),
BuildConfig.USER_AGENT, BuildConfig.SIGNAL_AGENT,
new PipeConnectivityListener(), new PipeConnectivityListener(),
sleepTimer); sleepTimer);
} }

4
app/src/main/java/org/thoughtcrime/securesms/push/AccountManagerFactory.java
View File

@ -36,7 +36,7 @@ public class AccountManagerFactory {
} }
return new SignalServiceAccountManager(new SignalServiceNetworkAccess(context).getConfiguration(number), return new SignalServiceAccountManager(new SignalServiceNetworkAccess(context).getConfiguration(number),
uuid, number, password, BuildConfig.USER_AGENT); uuid, number, password, BuildConfig.SIGNAL_AGENT);
} }
/** /**
@ -57,7 +57,7 @@ public class AccountManagerFactory {
} }
return new SignalServiceAccountManager(new SignalServiceNetworkAccess(context).getConfiguration(number), return new SignalServiceAccountManager(new SignalServiceNetworkAccess(context).getConfiguration(number),
null, number, password, BuildConfig.USER_AGENT); null, number, password, BuildConfig.SIGNAL_AGENT);
} }
} }

12
libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceAccountManager.java
View File

@ -95,22 +95,22 @@ public class SignalServiceAccountManager {
* @param uuid The Signal Service UUID. * @param uuid The Signal Service UUID.
* @param e164 The Signal Service phone number. * @param e164 The Signal Service phone number.
* @param password A Signal Service password. * @param password A Signal Service password.
* @param userAgent A string which identifies the client software. * @param signalAgent A string which identifies the client software.
*/ */
public SignalServiceAccountManager(SignalServiceConfiguration configuration, public SignalServiceAccountManager(SignalServiceConfiguration configuration,
UUID uuid, String e164, String password, UUID uuid, String e164, String password,
String userAgent) String signalAgent)
{ {
this(configuration, new StaticCredentialsProvider(uuid, e164, password, null), userAgent); this(configuration, new StaticCredentialsProvider(uuid, e164, password, null), signalAgent);
} }
public SignalServiceAccountManager(SignalServiceConfiguration configuration, public SignalServiceAccountManager(SignalServiceConfiguration configuration,
CredentialsProvider credentialsProvider, CredentialsProvider credentialsProvider,
String userAgent) String signalAgent)
{ {
this.pushServiceSocket = new PushServiceSocket(configuration, credentialsProvider, userAgent); this.pushServiceSocket = new PushServiceSocket(configuration, credentialsProvider, signalAgent);
this.credentials = credentialsProvider; this.credentials = credentialsProvider;
this.userAgent = userAgent; this.userAgent = signalAgent;
} }
public byte[] getSenderCertificate() throws IOException { public byte[] getSenderCertificate() throws IOException {

16
libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageReceiver.java
View File

@ -51,7 +51,7 @@ public class SignalServiceMessageReceiver {
private final PushServiceSocket socket; private final PushServiceSocket socket;
private final SignalServiceConfiguration urls; private final SignalServiceConfiguration urls;
private final CredentialsProvider credentialsProvider; private final CredentialsProvider credentialsProvider;
private final String userAgent; private final String signalAgent;
private final ConnectivityListener connectivityListener; private final ConnectivityListener connectivityListener;
private final SleepTimer sleepTimer; private final SleepTimer sleepTimer;
@ -66,11 +66,11 @@ public class SignalServiceMessageReceiver {
*/ */
public SignalServiceMessageReceiver(SignalServiceConfiguration urls, public SignalServiceMessageReceiver(SignalServiceConfiguration urls,
UUID uuid, String e164, String password, UUID uuid, String e164, String password,
String signalingKey, String userAgent, String signalingKey, String signalAgent,
ConnectivityListener listener, ConnectivityListener listener,
SleepTimer timer) SleepTimer timer)
{ {
this(urls, new StaticCredentialsProvider(uuid, e164, password, signalingKey), userAgent, listener, timer); this(urls, new StaticCredentialsProvider(uuid, e164, password, signalingKey), signalAgent, listener, timer);
} }
/** /**
@ -81,14 +81,14 @@ public class SignalServiceMessageReceiver {
*/ */
public SignalServiceMessageReceiver(SignalServiceConfiguration urls, public SignalServiceMessageReceiver(SignalServiceConfiguration urls,
CredentialsProvider credentials, CredentialsProvider credentials,
String userAgent, String signalAgent,
ConnectivityListener listener, ConnectivityListener listener,
SleepTimer timer) SleepTimer timer)
{ {
this.urls = urls; this.urls = urls;
this.credentialsProvider = credentials; this.credentialsProvider = credentials;
this.socket = new PushServiceSocket(urls, credentials, userAgent); this.socket = new PushServiceSocket(urls, credentials, signalAgent);
this.userAgent = userAgent; this.signalAgent = signalAgent;
this.connectivityListener = listener; this.connectivityListener = listener;
this.sleepTimer = timer; this.sleepTimer = timer;
} }
@ -199,7 +199,7 @@ public class SignalServiceMessageReceiver {
public SignalServiceMessagePipe createMessagePipe() { public SignalServiceMessagePipe createMessagePipe() {
WebSocketConnection webSocket = new WebSocketConnection(urls.getSignalServiceUrls()[0].getUrl(), WebSocketConnection webSocket = new WebSocketConnection(urls.getSignalServiceUrls()[0].getUrl(),
urls.getSignalServiceUrls()[0].getTrustStore(), urls.getSignalServiceUrls()[0].getTrustStore(),
Optional.of(credentialsProvider), userAgent, connectivityListener, Optional.of(credentialsProvider), signalAgent, connectivityListener,
sleepTimer); sleepTimer);
return new SignalServiceMessagePipe(webSocket, Optional.of(credentialsProvider)); return new SignalServiceMessagePipe(webSocket, Optional.of(credentialsProvider));
@ -208,7 +208,7 @@ public class SignalServiceMessageReceiver {
public SignalServiceMessagePipe createUnidentifiedMessagePipe() { public SignalServiceMessagePipe createUnidentifiedMessagePipe() {
WebSocketConnection webSocket = new WebSocketConnection(urls.getSignalServiceUrls()[0].getUrl(), WebSocketConnection webSocket = new WebSocketConnection(urls.getSignalServiceUrls()[0].getUrl(),
urls.getSignalServiceUrls()[0].getTrustStore(), urls.getSignalServiceUrls()[0].getTrustStore(),
Optional.<CredentialsProvider>absent(), userAgent, connectivityListener, Optional.<CredentialsProvider>absent(), signalAgent, connectivityListener,
sleepTimer); sleepTimer);
return new SignalServiceMessagePipe(webSocket, Optional.of(credentialsProvider)); return new SignalServiceMessagePipe(webSocket, Optional.of(credentialsProvider));

8
libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java
View File

@ -118,25 +118,25 @@ public class SignalServiceMessageSender {
public SignalServiceMessageSender(SignalServiceConfiguration urls, public SignalServiceMessageSender(SignalServiceConfiguration urls,
UUID uuid, String e164, String password, UUID uuid, String e164, String password,
SignalProtocolStore store, SignalProtocolStore store,
String userAgent, String signalAgent,
boolean isMultiDevice, boolean isMultiDevice,
Optional<SignalServiceMessagePipe> pipe, Optional<SignalServiceMessagePipe> pipe,
Optional<SignalServiceMessagePipe> unidentifiedPipe, Optional<SignalServiceMessagePipe> unidentifiedPipe,
Optional<EventListener> eventListener) Optional<EventListener> eventListener)
{ {
this(urls, new StaticCredentialsProvider(uuid, e164, password, null), store, userAgent, isMultiDevice, pipe, unidentifiedPipe, eventListener); this(urls, new StaticCredentialsProvider(uuid, e164, password, null), store, signalAgent, isMultiDevice, pipe, unidentifiedPipe, eventListener);
} }
public SignalServiceMessageSender(SignalServiceConfiguration urls, public SignalServiceMessageSender(SignalServiceConfiguration urls,
CredentialsProvider credentialsProvider, CredentialsProvider credentialsProvider,
SignalProtocolStore store, SignalProtocolStore store,
String userAgent, String signalAgent,
boolean isMultiDevice, boolean isMultiDevice,
Optional<SignalServiceMessagePipe> pipe, Optional<SignalServiceMessagePipe> pipe,
Optional<SignalServiceMessagePipe> unidentifiedPipe, Optional<SignalServiceMessagePipe> unidentifiedPipe,
Optional<EventListener> eventListener) Optional<EventListener> eventListener)
{ {
this.socket = new PushServiceSocket(urls, credentialsProvider, userAgent); this.socket = new PushServiceSocket(urls, credentialsProvider, signalAgent);
this.store = store; this.store = store;
this.localAddress = new SignalServiceAddress(credentialsProvider.getUuid(), credentialsProvider.getE164()); this.localAddress = new SignalServiceAddress(credentialsProvider.getUuid(), credentialsProvider.getE164());
this.pipe = new AtomicReference<>(pipe); this.pipe = new AtomicReference<>(pipe);

10
libsignal/service/src/main/java/org/whispersystems/signalservice/internal/push/PushServiceSocket.java
View File

@ -168,12 +168,12 @@ public class PushServiceSocket {
private final OkHttpClient attachmentClient; private final OkHttpClient attachmentClient;
private final CredentialsProvider credentialsProvider; private final CredentialsProvider credentialsProvider;
private final String userAgent; private final String signalAgent;
private final SecureRandom random; private final SecureRandom random;
public PushServiceSocket(SignalServiceConfiguration signalServiceConfiguration, CredentialsProvider credentialsProvider, String userAgent) { public PushServiceSocket(SignalServiceConfiguration signalServiceConfiguration, CredentialsProvider credentialsProvider, String signalAgent) {
this.credentialsProvider = credentialsProvider; this.credentialsProvider = credentialsProvider;
this.userAgent = userAgent; this.signalAgent = signalAgent;
this.serviceClients = createServiceConnectionHolders(signalServiceConfiguration.getSignalServiceUrls()); this.serviceClients = createServiceConnectionHolders(signalServiceConfiguration.getSignalServiceUrls());
this.cdnClients = createConnectionHolders(signalServiceConfiguration.getSignalCdnUrls()); this.cdnClients = createConnectionHolders(signalServiceConfiguration.getSignalCdnUrls());
this.contactDiscoveryClients = createConnectionHolders(signalServiceConfiguration.getSignalContactDiscoveryUrls()); this.contactDiscoveryClients = createConnectionHolders(signalServiceConfiguration.getSignalContactDiscoveryUrls());
@ -1068,8 +1068,8 @@ public class PushServiceSocket {
} }
} }
if (userAgent != null) { if (signalAgent != null) {
request.addHeader("X-Signal-Agent", userAgent); request.addHeader("X-Signal-Agent", signalAgent);
} }
if (connectionHolder.getHostHeader().isPresent()) { if (connectionHolder.getHostHeader().isPresent()) {

10
libsignal/service/src/main/java/org/whispersystems/signalservice/internal/websocket/WebSocketConnection.java
View File

@ -54,7 +54,7 @@ public class WebSocketConnection extends WebSocketListener {
private final String wsUri; private final String wsUri;
private final TrustStore trustStore; private final TrustStore trustStore;
private final Optional<CredentialsProvider> credentialsProvider; private final Optional<CredentialsProvider> credentialsProvider;
private final String userAgent; private final String signalAgent;
private final ConnectivityListener listener; private final ConnectivityListener listener;
private final SleepTimer sleepTimer; private final SleepTimer sleepTimer;
@ -66,13 +66,13 @@ public class WebSocketConnection extends WebSocketListener {
public WebSocketConnection(String httpUri, public WebSocketConnection(String httpUri,
TrustStore trustStore, TrustStore trustStore,
Optional<CredentialsProvider> credentialsProvider, Optional<CredentialsProvider> credentialsProvider,
String userAgent, String signalAgent,
ConnectivityListener listener, ConnectivityListener listener,
SleepTimer timer) SleepTimer timer)
{ {
this.trustStore = trustStore; this.trustStore = trustStore;
this.credentialsProvider = credentialsProvider; this.credentialsProvider = credentialsProvider;
this.userAgent = userAgent; this.signalAgent = signalAgent;
this.listener = listener; this.listener = listener;
this.sleepTimer = timer; this.sleepTimer = timer;
this.attempts = 0; this.attempts = 0;
@ -108,8 +108,8 @@ public class WebSocketConnection extends WebSocketListener {
Request.Builder requestBuilder = new Request.Builder().url(filledUri); Request.Builder requestBuilder = new Request.Builder().url(filledUri);
if (userAgent != null) { if (signalAgent != null) {
requestBuilder.addHeader("X-Signal-Agent", userAgent); requestBuilder.addHeader("X-Signal-Agent", signalAgent);
} }
if (listener != null) { if (listener != null) {