diff --git a/app/src/main/java/org/thoughtcrime/securesms/groups/ui/managegroup/dialogs/GroupRightsDialog.java b/app/src/main/java/org/thoughtcrime/securesms/groups/ui/managegroup/dialogs/GroupRightsDialog.java index 92d811f85..09afdbfc1 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/groups/ui/managegroup/dialogs/GroupRightsDialog.java +++ b/app/src/main/java/org/thoughtcrime/securesms/groups/ui/managegroup/dialogs/GroupRightsDialog.java @@ -47,10 +47,10 @@ public final class GroupRightsDialog { public enum Type { - MEMBERSHIP(R.string.GroupManagement_choose_who_can_add_or_invite_new_members, + MEMBERSHIP(R.string.ManageGroupActivity_choose_who_can_add_or_invite_new_members, R.array.GroupManagement_edit_group_membership_choices), - ATTRIBUTES(R.string.GroupManagement_choose_who_can_change_the_group_name_and_photo, + ATTRIBUTES(R.string.ManageGroupActivity_choose_who_can_edit_the_group_name_avatar_and_disappearing_messages, R.array.GroupManagement_edit_group_info_choices); @StringRes private final int message; diff --git a/app/src/main/res/layout/group_manage_fragment.xml b/app/src/main/res/layout/group_manage_fragment.xml index aac685ba2..dcea223f9 100644 --- a/app/src/main/res/layout/group_manage_fragment.xml +++ b/app/src/main/res/layout/group_manage_fragment.xml @@ -175,10 +175,10 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_weight="1" + android:gravity="end" android:minWidth="48dp" android:paddingStart="@dimen/group_manage_fragment_row_horizontal_padding" android:paddingEnd="@dimen/group_manage_fragment_row_horizontal_padding" - android:gravity="end" android:textAppearance="@style/Signal.Text.Body" android:textColor="@color/ultramarine_text_button" tools:text="Off" /> @@ -387,7 +387,7 @@ android:gravity="center_vertical|start" android:paddingStart="@dimen/group_manage_fragment_row_horizontal_padding" android:paddingEnd="@dimen/group_manage_fragment_row_horizontal_padding" - android:text="@string/ManageGroupActivity_who_can_edit_group_membership" + android:text="@string/ManageGroupActivity_add_members" android:textAlignment="viewStart" android:textAppearance="@style/Signal.Text.Body" /> @@ -395,8 +395,8 @@ android:id="@+id/edit_group_membership_value" android:layout_width="wrap_content" android:layout_height="match_parent" - android:gravity="center_vertical" - android:minWidth="48dp" + android:gravity="center_vertical|end" + android:minWidth="136dp" android:paddingStart="@dimen/group_manage_fragment_row_horizontal_padding" android:paddingEnd="@dimen/group_manage_fragment_row_horizontal_padding" android:textAppearance="@style/Signal.Text.Body" @@ -405,10 +405,10 @@ - @@ -416,28 +416,54 @@ + android:textAppearance="@style/Signal.Text.Body" + app:layout_constraintEnd_toStartOf="@+id/edit_group_access_value" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" /> - + + + + diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index d93712a99..63cc6ebbc 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -525,8 +525,10 @@ Disappearing messages Pending group invites - Who can edit group membership - Who can edit group info + Add members + Edit group info + Choose who can edit the group name, avatar, and disappearing messages. + Choose who can add or invite new members. Block group Unblock group Leave group @@ -535,7 +537,6 @@ Until %1$s Off On - Add members View all members See all @@ -560,9 +561,6 @@ Legacy Group This is a Legacy Group. To access features like group admins, create a New Group. - Choose who can add or invite new members - Choose who can change the group name and photo - Add to system contacts